Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Move #2206

Merged
merged 10 commits into from
Mar 12, 2020
Merged

feat: Move #2206

merged 10 commits into from
Mar 12, 2020

Conversation

cwhitten
Copy link
Member

@cwhitten cwhitten commented Mar 10, 2020

@cwhitten cwhitten changed the title Move feat: Move Mar 10, 2020
@github-actions
Copy link

Coverage Status

Coverage decreased (-0.04%) to 40.742% when pulling 05a02ee on cwhitten/move-func into ceb8186 on master.

cwhitten and others added 4 commits March 10, 2020 08:50
@yeze322
Copy link
Contributor

yeze322 commented Mar 11, 2020

After moving SendActivty or Input types to new dialog, lg templates will be lost.
Relies on #2236 to fix that problem.

a-b-r-o-w-n
a-b-r-o-w-n previously approved these changes Mar 11, 2020
Copy link
Contributor

@a-b-r-o-w-n a-b-r-o-w-n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks really awesome. I don't have any blocking feedback.

a-b-r-o-w-n
a-b-r-o-w-n previously approved these changes Mar 12, 2020
* dump real lg content before paste them

* implement lg resources walker

* update lg walker api

* split insertNodes from pasteNodes

* fix tslint

* change copyUtils ExtarnelAPI interface

* migrate to new api format

* create real lg template when pasting

* renaming

* update walkLgResources

* create lgTemplates for moved actions

* hack the debounce issue #2247

* Fix build

* Fix lint

Co-authored-by: Ze Ye <zeye@microsoft.com>
Co-authored-by: zeye <2295905420@qq.com>
@cwhitten cwhitten merged commit a9f7e66 into master Mar 12, 2020
@cwhitten cwhitten deleted the cwhitten/move-func branch March 12, 2020 19:05
@a-b-r-o-w-n a-b-r-o-w-n mentioned this pull request Mar 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants