feat: visual/move with lgapi #2258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tFramework-Composer into visual/shallow-copy
cwhitten
requested review from
a-b-r-o-w-n,
boydc2014 and
yeze322
as code owners
cwhitten
added a commit
that referenced
this pull request
Mar 12, 2020
* Implement Move * Rmemove dependency on query string * fix: sort action ids correctly (#2217) * sort actionIds by tree path order * filter invalid ids and update test cases * fix: make MoveSelection work (not target master) (#2234) * make MoveSelection work * add comments * initialDialogShape as a function * feat: visual/move with lgapi (#2258) * dump real lg content before paste them * implement lg resources walker * update lg walker api * split insertNodes from pasteNodes * fix tslint * change copyUtils ExtarnelAPI interface * migrate to new api format * create real lg template when pasting * renaming * update walkLgResources * create lgTemplates for moved actions * hack the debounce issue #2247 * Fix build * Fix lint Co-authored-by: Ze Ye <zeye@microsoft.com> Co-authored-by: zeye <2295905420@qq.com> Co-authored-by: zeye <2295905420@qq.com> Co-authored-by: Ze Ye <zeye@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #2258