Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: regEx trigger creation bug #2214

Merged
merged 2 commits into from
Mar 10, 2020
Merged

fix: regEx trigger creation bug #2214

merged 2 commits into from
Mar 10, 2020

Conversation

liweitian
Copy link
Contributor

@liweitian liweitian commented Mar 10, 2020 •
edited by cwhitten
Loading

Description

  1. Delete the regEx pattern when we delete the trigger which triggers it.
  2. Do not allow user to create an onIntent trigger when the recognizer type is None.

Task Item

closes #2215

Screenshots

aaaaa
aaaaa1

@a-b-r-o-w-n a-b-r-o-w-n changed the title fix: regEx creation bug fix: regEx trigger creation bug Mar 10, 2020
@a-b-r-o-w-n a-b-r-o-w-n merged commit d5f1776 into microsoft:master Mar 10, 2020
@cwhitten cwhitten mentioned this pull request Mar 11, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@a-b-r-o-w-n a-b-r-o-w-n a-b-r-o-w-n approved these changes

@boydc2014 boydc2014 Awaiting requested review from boydc2014 boydc2014 is a code owner

@cwhitten cwhitten Awaiting requested review from cwhitten cwhitten is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@liweitian @a-b-r-o-w-n @cwhitten