feat: Add OS selection to provisioning #8150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GeoffCoxMSFT
requested review from
a-b-r-o-w-n,
benbrown,
beyackle,
boydc2014,
cwhitten,
hatpick,
pavolum,
srinaath,
tdurnford and
tonyanziano
as code owners
hatpick
reviewed
Jun 21, 2021
extensions/azurePublish/src/node/azureResourceManager/azureResourceManager.ts
Outdated
Show resolved
Hide resolved
hatpick
approved these changes
Jun 21, 2021
hatpick
approved these changes
Jun 21, 2021
|
Test summary
Run details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds operating system selection of Windows or Linux based on the design.
Caveat: Have not yet provided the recommended OS dynamically based on project yet
Tested that the correct operating system was provisioned for the App Service (and App Service Plan) for the following combinations of project type, runtime, and OS selection:
Task Item
refs #8063
fixes #8127
Screenshots