Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add OS selection to provisioning #8150

Merged
merged 5 commits into from
Jun 21, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Composer/packages/client/src/pages/publish/styles.ts
Original file line number Diff line number Diff line change
Expand Up @@ -150,5 +150,5 @@ export const pvaPublishSurface = css`
export const azurePublishSurface = css`
overflow-x: hidden;
overflow-y: auto;
height: 500px;
height: 550px;
`;
Original file line number Diff line number Diff line change
Expand Up @@ -155,7 +155,7 @@ const ImportActionContent = () => {
<Text>- {formatMessage('Microsoft Application Registration')}</Text>
</ResourceTitle>
<ResourceTitle>
<Text>- {formatMessage('Azure Hosting')}</Text>
<Text>- {formatMessage('App Services')}</Text>
</ResourceTitle>
<ResourceTitle>
<Text>- {formatMessage('Microsoft Bot Channels Registration')}</Text>
Expand Down
43 changes: 43 additions & 0 deletions extensions/azurePublish/src/components/azureProvisionDialog.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,8 @@ import {
IStackTokens,
IStackItemStyles,
Link,
ChoiceGroup,
IChoiceGroupOption,
} from 'office-ui-fabric-react';
import { MessageBar, MessageBarType } from 'office-ui-fabric-react/lib/MessageBar';
import { JsonEditor } from '@bfc/code-editor';
Expand Down Expand Up @@ -71,6 +73,7 @@ type ProvisionFormData = {
hostname: string;
region: string;
luisLocation: string;
appServiceOperatingSystem: string;
GeoffCoxMSFT marked this conversation as resolved.
Show resolved Hide resolved
enabledResources: ResourcesItem[];
requiredResources: ResourcesItem[];
};
Expand Down Expand Up @@ -130,6 +133,14 @@ const LearnMoreLink = styled(Link)`
font-size: 14px;
`;

const appOSChoiceGroupStyles = {
flexContainer: { display: 'flex', flexDirection: 'row' },
};

const appOSChoiceGroupOptionStyles = {
root: { marginLeft: '8px' },
};

const PageTypes = {
ChooseAction: 'chooseAction',
ConfigProvision: 'config',
Expand Down Expand Up @@ -289,11 +300,15 @@ const getDefaultFormData = (currentProfile, defaults) => {
hostname: getHostname(currentProfile) ?? defaults.hostname,
region: currentProfile?.region ?? defaults.region,
luisLocation: currentProfile?.settings?.luis?.region ?? defaults.luisLocation,
appServiceOperatingSystem:
currentProfile?.settings?.appServiceOperatingSystem ?? defaults.appServiceOperatingSystem,
enabledResources: defaults.enabledResources ?? [],
requiredResources: defaults.requireResources ?? [],
};
};

const defaultAppServiceOperatingSystem = 'windows';

export const AzureProvisionDialog: React.FC = () => {
const {
currentProjectId,
Expand Down Expand Up @@ -846,6 +861,11 @@ export const AzureProvisionDialog: React.FC = () => {
);
};

const appServiceOSOptions: IChoiceGroupOption[] = [
{ key: 'windows', text: 'Windows' },
{ key: 'linux', text: 'Linux', styles: appOSChoiceGroupOptionStyles },
];

const PageFormConfig = (
<ScrollablePane
data-is-scrollable="true"
Expand Down Expand Up @@ -922,6 +942,28 @@ export const AzureProvisionDialog: React.FC = () => {
}}
/>
</Stack>
<ConfigureResourcesSectionName>
{formatMessage('App Service (Web App or Function)')}
</ConfigureResourcesSectionName>
<Stack horizontal tokens={configureResourcePropertyStackTokens} verticalAlign="start">
<Stack horizontal styles={configureResourcePropertyLabelStackStyles} verticalAlign="center">
<ConfigureResourcesPropertyLabel required>
{formatMessage('Operating System')}
</ConfigureResourcesPropertyLabel>
{renderPropertyInfoIcon(
formatMessage('Select the operating system that will host your application service.')
)}
</Stack>
<ChoiceGroup
required
defaultSelectedKey={defaultAppServiceOperatingSystem}
options={appServiceOSOptions}
styles={appOSChoiceGroupStyles}
onChange={(_e, o) => {
updateFormData('appServiceOperatingSystem', o.key as string);
}}
/>
</Stack>
<ConfigureResourcesSectionName>{formatMessage('Resource details')}</ConfigureResourcesSectionName>
<ConfigureResourcesSectionDescription>
{formatMessage('Enter resource name and select region. This will be applied to the new resources.')}
Expand Down Expand Up @@ -1249,6 +1291,7 @@ export const AzureProvisionDialog: React.FC = () => {
hostname: formData.hostname,
location: formData.region,
luisLocation: formData.luisLocation || formData.region,
appServiceOperatingSystem: formData.appServiceOperatingSystem,
type: publishType,
externalResources: selectedResources,
});
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -778,12 +778,16 @@ export class AzureResourceMananger {
});
const webSiteManagementClient = new WebSiteManagementClient(this.creds, this.subscriptionId);

const operatingSystem = config.operatingSystem ? config.operatingSystem : 'windows';

// Create new Service Plan
const servicePlanResult = await webSiteManagementClient.appServicePlans.createOrUpdate(
config.resourceGroupName,
config.name,
{
location: config.location,
kind: operatingSystem,
reserved: operatingSystem === 'linux',
sku: {
name: 'S1',
tier: 'Standard',
Expand All @@ -807,7 +811,7 @@ export class AzureResourceMananger {
name: webAppName,
serverFarmId: servicePlanResult.name,
location: config.location,
kind: 'app',
kind: operatingSystem === 'linux' ? 'app,linux' : 'app',
siteConfig: {
webSocketsEnabled: true,
appSettings: [
Expand Down Expand Up @@ -853,14 +857,18 @@ export class AzureResourceMananger {
});
const webSiteManagementClient = new WebSiteManagementClient(this.creds, this.subscriptionId);
const azureFunctionsName = config.name;

const operatingSystem = config.operatingSystem ? config.operatingSystem : 'windows';

const azureFunctionsResult = await webSiteManagementClient.webApps.createOrUpdate(
config.resourceGroupName,
config.name,
{
name: azureFunctionsName,
location: config.location,
kind: 'functionapp',
kind: operatingSystem === 'linux' ? 'functionapp,linux' : 'functionapp',
httpsOnly: true,
reserved: operatingSystem === 'linux',
siteConfig: {
webSocketsEnabled: true,
appSettings: [
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -104,6 +104,7 @@ export interface WebAppConfig {
sku?: string;
appId?: string;
appPwd?: string;
operatingSystem?: string;
}

export interface AzureFunctionsConfig {
Expand All @@ -119,6 +120,7 @@ export interface AzureFunctionsConfig {
* Currently documented values: dotnet, node, java, python, or powershell
*/
workerRuntime?: string;
operatingSystem?: string;
}

export interface DeploymentsConfig {
Expand Down
2 changes: 2 additions & 0 deletions extensions/azurePublish/src/node/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -316,6 +316,8 @@ export default async (composer: IExtensionRegistration): Promise<void> => {
: currentProfile?.luisResource,
runtimeIdentifier: currentProfile?.runtimeIdentifier ?? 'win-x64',
region: provisionConfig.location,
appServiceOperatingSystem:
provisionConfig.appServiceOperatingSystem ?? currentProfile?.appServiceOperatingSystem,
settings: {
applicationInsights: {
InstrumentationKey:
Expand Down
3 changes: 3 additions & 0 deletions extensions/azurePublish/src/node/provision.ts
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ export interface ProvisionConfig {
externalResources: ResourceType[];
location: string;
luisLocation: string;
appServiceOperatingSystem?: string;
subscription: string;
resourceGroup?: string;
logger?: (string) => any;
Expand Down Expand Up @@ -301,6 +302,7 @@ export class BotProjectProvision {
resourceGroupName: resourceGroupName,
location: config.location ?? provisionResults.resourceGroup.location,
name: config.hostname,
operatingSystem: config.appServiceOperatingSystem,
});
provisionResults.webApp = {
hostname: hostname,
Expand Down Expand Up @@ -335,6 +337,7 @@ export class BotProjectProvision {
workerRuntime: config.workerRuntime,
appId: provisionResults.appId,
appPwd: provisionResults.appPassword,
operatingSystem: config.appServiceOperatingSystem,
});
provisionResults.webApp = {
hostname: functionsHostName,
Expand Down
2 changes: 1 addition & 1 deletion extensions/azurePublish/src/node/resourceTypes.ts
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ export const AzureResourceTypes = {
SERVICE_PLAN: 'servicePlan',
};

const hostingGroupName = 'Azure Hosting';
const hostingGroupName = 'App Services';
const cognitiveServicesGroupName = 'Cognitive Services';

export const AzureResourceDefinitions = {
Expand Down
5 changes: 5 additions & 0 deletions extensions/azurePublish/src/node/schema.ts
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,10 @@ const schema: JSONSchema7 = {
type: 'string',
title: 'region of your resource group',
},
appServiceOperatingSystem: {
type: 'string',
title: "The operating system for the App Service. 'windows' or 'linux'.",
},
settings: {
type: 'object',
title: 'Settings for Azure resources',
Expand Down Expand Up @@ -150,6 +154,7 @@ const schema: JSONSchema7 = {
botName: '<name of your bot channel registration>',
subscriptionId: '<id of your subscription>',
region: '<region of your resource group>',
appServiceOperatingSystem: 'windows',
settings: {
applicationInsights: {
InstrumentationKey: '<Instrumentation Key>',
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ export const ImportInstructionsStep = () => {
<Text>- {formatMessage('Microsoft Application Registration')}</Text>
</ResourceTitle>
<ResourceTitle>
<Text>- {formatMessage('Azure Hosting')}</Text>
<Text>- {formatMessage('App Services')}</Text>
</ResourceTitle>
<ResourceTitle>
<Text>- {formatMessage('Microsoft Bot Channels Registration')}</Text>
Expand Down