fix: Adding fallback logic for readMe acquisition #8307
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
in the root of npm registry response
pavolum
requested review from
a-b-r-o-w-n,
benbrown,
beyackle,
boydc2014,
cwhitten,
GeoffCoxMSFT,
hatpick,
natalgar,
srinaath,
tdurnford,
tonyanziano and
VamsiModem
as code owners
benbrown
previously approved these changes
Jul 9, 2021
cwhitten
reviewed
Jul 9, 2021
|
Test summary
Run details
View run in Cypress Dashboard ➡️ Flakiness
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
||||||||||||||||||||||||||
hatpick
reviewed
Jul 9, 2021
benbrown
approved these changes
Jul 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We recently found out that pushing preview versions of packages changes where the readMe is stored in the npm registry API response.
This PR enhances the readme parsing logic to account for this api behavior.
If the readme is not at the root of the api response Composer will now look for it within the versions dictionary in the response. It searches the versions starting from the most recently published version and returning the first readMe it finds.
If no readme is found then we render error text in the readMe section of template selection as opposed to no text.
Task Item
fixes #8294
Screenshots