Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Adding fallback logic for readMe acquisition #8307

Merged
merged 7 commits into from
Jul 9, 2021
Merged

fix: Adding fallback logic for readMe acquisition #8307

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
098d70e
Adding fallback logic if readMe is not
pavolum Jul 9, 2021
caff4b6
Merge branch 'main' into pavolum/backupLogicForReadmeCall
pavolum Jul 9, 2021
b1dfae4
Fixing version order by ensuring correct order based on published tim…
pavolum Jul 9, 2021
f6e7e46
Adding comments to sort logic
pavolum Jul 9, 2021
7f18101
Simplifying with Object.entries()
pavolum Jul 9, 2021
d1b7990
Merge branch 'main' into pavolum/backupLogicForReadmeCall
pavolum Jul 9, 2021
136d66c
Merge branch 'main' into pavolum/backupLogicForReadmeCall
pavolum Jul 9, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
19 changes: 15 additions & 4 deletions Composer/packages/server/src/controllers/asset.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,10 +124,21 @@ export async function getTemplateReadMe(req: any, res: any) {
// if no readme at root then pull readme from latest published version that has one
if (!readMe) {
const versionsDict = data?.versions;
if (versionsDict && Object.keys(versionsDict).length > 0) {
for (const versionKey of Object.keys(versionsDict).reverse()) {
if (versionsDict[versionKey] && versionsDict[versionKey]?.readme) {
readMe = versionsDict[versionKey].readme;
const versionTimesObj = data?.time;
if (versionsDict && versionTimesObj) {
const items = Object.keys(versionTimesObj).map((key) => {
pavolum marked this conversation as resolved.
Show resolved Hide resolved
return [key, versionTimesObj[key]];
});

items.sort((firstEntry, secondEntry) => {
const firstEntryDate = new Date(firstEntry[1]).getTime();
const secondEntryDate = new Date(secondEntry[1]).getTime();
return firstEntryDate > secondEntryDate ? 1 : -1;
});

for (let i = items.length - 1; i > -1; i--) {
if (versionsDict[items[i][0]] && versionsDict[items[i][0]]?.readme) {
readMe = versionsDict[items[i][0]]?.readme;
break;
}
}
Expand Down