Fixed an accessibility issue with link descriptiveness.

microsoft · Sep 6, 2019 · f894f61 · f894f61
1 parent c87a412
commit f894f61
Show file tree

Hide file tree

Showing 6 changed files with 34 additions and 6 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -34,6 +34,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
   - [1832](https://github.com/microsoft/BotFramework-Emulator/pull/1832)
   - [1835](https://github.com/microsoft/BotFramework-Emulator/pull/1835)
   - [1836](https://github.com/microsoft/BotFramework-Emulator/pull/1836)
+  - [1838](https://github.com/microsoft/BotFramework-Emulator/pull/1838)
   - [1843](https://github.com/microsoft/BotFramework-Emulator/pull/1843)
 - [client] Fixed an issue with the transcripts path input inside of the resource settings dialog in PR [1836](https://github.com/microsoft/BotFramework-Emulator/pull/1836)
 

diff --git a/packages/app/client/src/ui/dialogs/botCreationDialog/botCreationDialog.tsx b/packages/app/client/src/ui/dialogs/botCreationDialog/botCreationDialog.tsx
@@ -148,7 +148,12 @@ export class BotCreationDialog extends React.Component<{}, BotCreationDialogStat
           </Row>
           <Row align={RowAlignment.Bottom}>
             <Checkbox label="Azure for US Government" checked={isAzureGov} onChange={this.onChannelServiceChange} />
-            <a href="https://aka.ms/bot-framework-emulator-azuregov">&nbsp;Learn more.</a>
+            <a
+              href="https://aka.ms/bot-framework-emulator-azuregov"
+              aria-label="Learn more about Azure for US Government"
+            >
+              &nbsp;Learn more.
+            </a>
           </Row>
           <Row align={RowAlignment.Bottom}>
             <Checkbox
@@ -157,7 +162,12 @@ export class BotCreationDialog extends React.Component<{}, BotCreationDialogStat
               checked={encryptKey}
               onChange={this.onEncryptKeyChange}
             />
-            <a href="https://aka.ms/bot-framework-bot-file-encryption">&nbsp;Learn more.</a>
+            <a
+              href="https://aka.ms/bot-framework-bot-file-encryption"
+              aria-label="Learn more about bot file encryption"
+            >
+              &nbsp;Learn more.
+            </a>
           </Row>
 
           <TextField

diff --git a/packages/app/client/src/ui/dialogs/botSettingsEditor/botSettingsEditor.tsx b/packages/app/client/src/ui/dialogs/botSettingsEditor/botSettingsEditor.tsx
@@ -114,7 +114,11 @@ export class BotSettingsEditor extends React.Component<BotSettingsEditorProps, B
             checked={encryptKey}
             onChange={this.onEncryptKeyChange}
           />
-          <a href="javascript:void(0);" onClick={this.onLearnMoreEncryptionClick}>
+          <a
+            href="javascript:void(0);"
+            onClick={this.onLearnMoreEncryptionClick}
+            aria-label="Learn more about bot file encryption"
+          >
             &nbsp;Learn more.
           </a>
         </Row>

diff --git a/packages/app/client/src/ui/dialogs/openBotDialog/openBotDialog.tsx b/packages/app/client/src/ui/dialogs/openBotDialog/openBotDialog.tsx
@@ -178,7 +178,12 @@ export class OpenBotDialog extends Component<OpenBotDialogProps, OpenBotDialogSt
               checked={isAzureGov}
               onClick={this.onChannelServiceCheckboxClick}
             />
-            <a href="https://aka.ms/bot-framework-emulator-azuregov">&nbsp;Learn more.</a>
+            <a
+              href="https://aka.ms/bot-framework-emulator-azuregov"
+              aria-label="Learn more about Azure for US Government"
+            >
+              &nbsp;Learn more.
+            </a>
           </Row>
           <DialogFooter>
             <DefaultButton type="button" onClick={this.props.onDialogCancel}>

diff --git a/packages/app/client/src/ui/editor/emulator/parts/inspector/inspector.tsx b/packages/app/client/src/ui/editor/emulator/parts/inspector/inspector.tsx
@@ -224,7 +224,10 @@ export class Inspector extends React.Component<InspectorProps, InspectorState> {
                 {
                   'You can also inspect the JSON responses from your LUIS and QnA Maker services by selecting a "trace" activity. '
                 }
-                <a href="https://docs.microsoft.com/en-us/azure/bot-service/bot-service-debug-emulator?view=azure-bot-service-4.0">
+                <a
+                  href="https://docs.microsoft.com/en-us/azure/bot-service/bot-service-debug-emulator?view=azure-bot-service-4.0"
+                  aria-label="Learn more about debugging your bot with the Emulator"
+                >
                   Learn More.
                 </a>
               </div>

diff --git a/packages/app/client/src/ui/shell/explorer/endpointExplorer/endpointEditor/endpointEditor.tsx b/packages/app/client/src/ui/shell/explorer/endpointExplorer/endpointEditor/endpointEditor.tsx
@@ -188,7 +188,12 @@ export class EndpointEditor extends Component<EndpointEditorProps, EndpointEdito
         />
         <Row align={RowAlignment.Center}>
           <Checkbox label="Azure for US Government" checked={isUsGov} onChange={this.onChannelServiceChange} />
-          <a href="https://aka.ms/bot-framework-emulator-azuregov">&nbsp;Learn more.</a>
+          <a
+            href="https://aka.ms/bot-framework-emulator-azuregov"
+            aria-label="Learn more about Azure for US Government"
+          >
+            &nbsp;Learn more.
+          </a>
         </Row>
         <a
           href="javascript:void(0)"