Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bot Inspector] Paged State-Diffing #1565

Closed
cwhitten opened this issue May 11, 2019 · 2 comments · Fixed by #1658
Closed

[Bot Inspector] Paged State-Diffing #1565

cwhitten opened this issue May 11, 2019 · 2 comments · Fixed by #1658
Assignees
Labels
Design Design Team issue Enhancement New feature or request to evolve an additional feature

Comments

@cwhitten
Copy link
Member

cwhitten commented May 11, 2019

Paged State-Diffing

Currently to move into state diff mode one has to open a context menu (right-click) and select an option from that menu to render the diff. This was a temporary solution until we had the cycles to build state-diff paging into the Bot State Inspector panel, where you can both move into state diff mode on a given Bot State, and page forward/backward to future/previous bot state diffs via buttons.

High-level code changes

  • Introduce new buttons in or near the bot state extension to move into and out of state diff mode and page through state diff modes when currently in state diff mode.
  • Extension manifest change to support Icons
  • Adjustment of the Bot State context menu in the chat control to no longer provide the menu item.
  • Provide the extension with all current Activities so it can maintain its own state.
@cwhitten cwhitten added Enhancement New feature or request to evolve an additional feature Design Design Team issue 4.5 labels May 11, 2019
@cwhitten cwhitten changed the title [Bot Inspector] [Bot Inspector] Paged State-Diffing May 11, 2019
@cwhitten
Copy link
Member Author

@mewa1024 can you attach the related design assets to this ticket?

@mewa1024
Copy link

These are the designs are a little stale, but my original thought was that the commands for inspect mode (called "Debugging mode" in the comps) should have a menu from the app's menu bar like this:
image

Paging would also be avaible in the inspector pane as icons in the upper right. The "<" means go to previous state, ">" means go to next state, and the map marker icon means resume from here. ">" and the map marker would be disabled if you were on the latest state:
image
image

cwhitten pushed a commit that referenced this issue Jul 2, 2019
* Intitial commit for bot state diffing

* Transfered the bf-extension buttons from the botState to the json extension

* Progress on extension bot state diffing

* Lint

* Highlighting and pagination

* Fixed accessory button styling.

* Completed major work

* removed botState extension

* Unit tests

* added missing unit test

* Lint fixes

* Removed unused extension

* Removed commented code

* Removed unneeded code
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Design Design Team issue Enhancement New feature or request to evolve an additional feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants