Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Emulator doesn't show deep link for ABS service #941

Closed
tomlm opened this issue Sep 30, 2018 · 3 comments · Fixed by #1066
Closed

Emulator doesn't show deep link for ABS service #941

tomlm opened this issue Sep 30, 2018 · 3 comments · Fixed by #1066
Labels
Design Design Team issue P1 Painful if we don't fix, won't block releasing Triaged Reviewed by the Triage Team

Comments

@tomlm
Copy link
Contributor

tomlm commented Sep 30, 2018

Version

image

Describe the bug

My bot file has an ABS record, and the services panel is not showing the ABS record and is not creating a deep link to the portal.

To Reproduce

Steps to reproduce the behavior:

  1. msbot connect bot …
  2. load bot file
  3. Services section doesn't show Bot, there is no deep link'

Expected behavior

Deep link to ABS portal

[bug]
@corinagum corinagum added the Bug Your classic code defect label Oct 1, 2018
@vishwacsena vishwacsena added v4 and removed v4 labels Oct 9, 2018
@sgellock sgellock changed the title Emulator is doesn't show deep link for ABS service Emulator doesn't show deep link for ABS service Oct 9, 2018
@sgellock sgellock added Approved Approved by the Triage team P1 Painful if we don't fix, won't block releasing v4.1 labels Oct 9, 2018
justinwilaby pushed a commit that referenced this issue Oct 10, 2018
#941 - Added ABS to the list of services in the service explorer.
8512aaf
@justinwilaby
Copy link
Contributor

#972 addresses the ABS listing in the services explorer. Since this service is connected to an endpoint, the ability to edit this service from the context menu has beed disabled.

justinwilaby pushed a commit that referenced this issue Oct 11, 2018
Merge branch 'v4' of github.com:Microsoft/BotFramework-Emulator into …
d10629c 
…jwilaby/#941-abs-deep-links
@justinwilaby justinwilaby added Design Design Team issue and removed Approved Approved by the Triage team Bug Your classic code defect v4.1 labels Oct 12, 2018
@justinwilaby
Copy link
Contributor

on hold pending design.

justinwilaby pushed a commit that referenced this issue Oct 12, 2018
Merge branch 'v4' into jwilaby/#941-abs-deep-links
9be1034
@mewa1024
Copy link

@tomlm @vishwacsena For the design of the pane, we decided not to separate the ABS service from the endpoint because it seemed redundant and potentially confusing:
317169756

Would this be sufficient?

The complete flow is on Invision: https://microsoft-fuse-design.invisionapp.com/d/main#/projects/prototypes/15012340

@sgellock sgellock added the v4.2 label Oct 15, 2018
@sgellock sgellock added the Triaged Reviewed by the Triage Team label Oct 15, 2018
justinwilaby added a commit that referenced this issue Oct 31, 2018
@justinwilaby
#941 - added ABS deep linking in the endpoints expolorer
d2723c0
@justinwilaby justinwilaby mentioned this issue Oct 31, 2018
Merged
justinwilaby pushed a commit that referenced this issue Oct 31, 2018
Merge branch 'master' into jwilaby/#941-ABS-deep-linking
969e983
justinwilaby pushed a commit that referenced this issue Oct 31, 2018
Merge pull request #1066 from Microsoft/jwilaby/#941-ABS-deep-linking
057dc8b 
#941 - added ABS deep linking in the endpoints expolorer
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Design Design Team issue P1 Painful if we don't fix, won't block releasing Triaged Reviewed by the Triage Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#941 - added ABS deep linking in the endpoints expolorer microsoft/BotFramework-Emulator
7 participants
@sgellock @justinwilaby @tonyanziano @corinagum @tomlm @vishwacsena @mewa1024