Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#941 - added ABS deep linking in the endpoints expolorer #1066

Merged
merged 2 commits into from
Oct 31, 2018
Merged

#941 - added ABS deep linking in the endpoints expolorer #1066

merged 2 commits into from
Oct 31, 2018

Conversation

justinwilaby
Copy link
Contributor

resolves #941

@coveralls
Copy link

coveralls commented Oct 31, 2018 •
edited

Pull Request Test Coverage Report for Build 1178

  • 18 of 20 (90.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.8%) to 54.23%
Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/app/client/src/data/sagas/endpointSagas.ts 11 13 84.62%
Totals Coverage Status
Change from base Build 1176: 0.8%
Covered Lines: 4267
Relevant Lines: 7103
💛 - Coveralls

tonyanziano
tonyanziano approved these changes Oct 31, 2018
View reviewed changes
Copy link
Contributor

@tonyanziano tonyanziano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@justinwilaby justinwilaby merged commit 057dc8b into master Oct 31, 2018
@justinwilaby justinwilaby deleted the jwilaby/#941-ABS-deep-linking branch October 31, 2018 18:13
@snyk-bot snyk-bot mentioned this pull request Aug 22, 2020
Open
@snyk-bot snyk-bot mentioned this pull request Sep 23, 2020
Open
@snyk-bot snyk-bot mentioned this pull request Jan 18, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tonyanziano tonyanziano tonyanziano approved these changes

@tomlm tomlm Awaiting requested review from tomlm

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Emulator doesn't show deep link for ABS service
3 participants
@justinwilaby @coveralls @tonyanziano