Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed error thrown when cancelling opening a transcript. #1441

Merged
merged 1 commit into from
Apr 22, 2019
Merged

Fixed error thrown when cancelling opening a transcript. #1441

merged 1 commit into from
Apr 22, 2019

Conversation

tonyanziano
Copy link
Contributor

Fixes #1432

@tonyanziano tonyanziano changed the title Fixed error thrown when cancelling open a transcript. Fixed error thrown when cancelling opening a transcript. Apr 22, 2019
@coveralls
Copy link

coveralls commented Apr 22, 2019 •
edited
Loading

Pull Request Test Coverage Report for Build 2454

  • 3 of 4 (75.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 56.789%
Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/app/client/src/commands/emulatorCommands.ts 3 4 75.0%
Totals Coverage Status
Change from base Build 2448: 0.0%
Covered Lines: 5242
Relevant Lines: 8677
💛 - Coveralls

@tonyanziano tonyanziano merged commit 054f455 into master Apr 22, 2019
@tonyanziano tonyanziano deleted the toanzian/#1432-xs branch April 22, 2019 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@corinagum corinagum corinagum approved these changes

@a-b-r-o-w-n a-b-r-o-w-n Awaiting requested review from a-b-r-o-w-n

@compulim compulim Awaiting requested review from compulim

@cwhitten cwhitten Awaiting requested review from cwhitten

@justinwilaby justinwilaby Awaiting requested review from justinwilaby

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cancelling out of opening a transcript spawns a broken transcript window
3 participants
@tonyanziano @coveralls @corinagum