Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed input grouping semantics in app settings editor. #1776

Merged
merged 2 commits into from Aug 22, 2019

Conversation

@tonyanziano
Copy link
Contributor

tonyanziano commented Aug 22, 2019

Addresses #1768

===

Inputs within each of the App Settings sections will now be prefaced by their respective headings when using a screen reader.

image

Ex: "Application Updates grouping. Automatically download and install updates checkbox unchecked."

@tonyanziano tonyanziano force-pushed the toanzian/acc-#1768 branch from f9a1758 to 6e4f418 Aug 22, 2019
@coveralls

This comment has been minimized.

Copy link

coveralls commented Aug 22, 2019

Coverage Status

Coverage remained the same at 65.342% when pulling f769bdd on toanzian/acc-#1768 into 997df8e on master.

Copy link
Member

corinagum left a comment

Pretty cool - fieldset and legend are new for me

@tonyanziano

This comment has been minimized.

Copy link
Contributor Author

tonyanziano commented Aug 22, 2019

@corinagum same. 😅

@tonyanziano tonyanziano merged commit 55f9db9 into master Aug 22, 2019
2 checks passed
2 checks passed
Emulator-CI-PR #76469 succeeded
Details
license/cla All CLA requirements met.
Details
@tonyanziano tonyanziano deleted the toanzian/acc-#1768 branch Aug 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.