Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#1795] Fixed an accessibility issue with link descriptiveness. #1838

Merged
merged 1 commit into from
Sep 6, 2019
Merged

[#1795] Fixed an accessibility issue with link descriptiveness. #1838

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
- [1832](https://github.com/microsoft/BotFramework-Emulator/pull/1832)
- [1835](https://github.com/microsoft/BotFramework-Emulator/pull/1835)
- [1836](https://github.com/microsoft/BotFramework-Emulator/pull/1836)
- [1838](https://github.com/microsoft/BotFramework-Emulator/pull/1838)
- [1843](https://github.com/microsoft/BotFramework-Emulator/pull/1843)
- [client] Fixed an issue with the transcripts path input inside of the resource settings dialog in PR [1836](https://github.com/microsoft/BotFramework-Emulator/pull/1836)

Expand Down
14 changes: 12 additions & 2 deletions packages/app/client/src/ui/dialogs/botCreationDialog/botCreationDialog.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,7 +148,12 @@ export class BotCreationDialog extends React.Component<{}, BotCreationDialogStat
</Row>
<Row align={RowAlignment.Bottom}>
<Checkbox label="Azure for US Government" checked={isAzureGov} onChange={this.onChannelServiceChange} />
<a href="https://aka.ms/bot-framework-emulator-azuregov">&nbsp;Learn more.</a>
<a
href="https://aka.ms/bot-framework-emulator-azuregov"
aria-label="Learn more about Azure for US Government"
>
&nbsp;Learn more.
</a>
</Row>
<Row align={RowAlignment.Bottom}>
<Checkbox
Expand All @@ -157,7 +162,12 @@ export class BotCreationDialog extends React.Component<{}, BotCreationDialogStat
checked={encryptKey}
onChange={this.onEncryptKeyChange}
/>
<a href="https://aka.ms/bot-framework-bot-file-encryption">&nbsp;Learn more.</a>
<a
href="https://aka.ms/bot-framework-bot-file-encryption"
aria-label="Learn more about bot file encryption"
>
&nbsp;Learn more.
</a>
</Row>

<TextField
Expand Down
6 changes: 5 additions & 1 deletion packages/app/client/src/ui/dialogs/botSettingsEditor/botSettingsEditor.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,11 @@ export class BotSettingsEditor extends React.Component<BotSettingsEditorProps, B
checked={encryptKey}
onChange={this.onEncryptKeyChange}
/>
<a href="javascript:void(0);" onClick={this.onLearnMoreEncryptionClick}>
<a
href="javascript:void(0);"
onClick={this.onLearnMoreEncryptionClick}
aria-label="Learn more about bot file encryption"
>
&nbsp;Learn more.
</a>
</Row>
Expand Down
7 changes: 6 additions & 1 deletion packages/app/client/src/ui/dialogs/openBotDialog/openBotDialog.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -178,7 +178,12 @@ export class OpenBotDialog extends Component<OpenBotDialogProps, OpenBotDialogSt
checked={isAzureGov}
onClick={this.onChannelServiceCheckboxClick}
/>
<a href="https://aka.ms/bot-framework-emulator-azuregov">&nbsp;Learn more.</a>
<a
href="https://aka.ms/bot-framework-emulator-azuregov"
aria-label="Learn more about Azure for US Government"
>
&nbsp;Learn more.
</a>
</Row>
<DialogFooter>
<DefaultButton type="button" onClick={this.props.onDialogCancel}>
Expand Down
5 changes: 4 additions & 1 deletion packages/app/client/src/ui/editor/emulator/parts/inspector/inspector.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -224,7 +224,10 @@ export class Inspector extends React.Component<InspectorProps, InspectorState> {
{
'You can also inspect the JSON responses from your LUIS and QnA Maker services by selecting a "trace" activity. '
}
<a href="https://docs.microsoft.com/en-us/azure/bot-service/bot-service-debug-emulator?view=azure-bot-service-4.0">
<a
href="https://docs.microsoft.com/en-us/azure/bot-service/bot-service-debug-emulator?view=azure-bot-service-4.0"
aria-label="Learn more about debugging your bot with the Emulator"
>
Learn More.
</a>
</div>
Expand Down
7 changes: 6 additions & 1 deletion packages/app/client/src/ui/shell/explorer/endpointExplorer/endpointEditor/endpointEditor.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -188,7 +188,12 @@ export class EndpointEditor extends Component<EndpointEditorProps, EndpointEdito
/>
<Row align={RowAlignment.Center}>
<Checkbox label="Azure for US Government" checked={isUsGov} onChange={this.onChannelServiceChange} />
<a href="https://aka.ms/bot-framework-emulator-azuregov">&nbsp;Learn more.</a>
<a
href="https://aka.ms/bot-framework-emulator-azuregov"
aria-label="Learn more about Azure for US Government"
>
&nbsp;Learn more.
</a>
</Row>
<a
href="javascript:void(0)"
Expand Down