Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#1822] Improved heading accessibility on welcome page. #1860

Merged
merged 1 commit into from
Sep 10, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
- [1855](https://github.com/microsoft/BotFramework-Emulator/pull/1855)
- [1856](https://github.com/microsoft/BotFramework-Emulator/pull/1856)
- [1858](https://github.com/microsoft/BotFramework-Emulator/pull/1858)
- [1860](https://github.com/microsoft/BotFramework-Emulator/pull/1860)

- [client] Fixed an issue with the transcripts path input inside of the resource settings dialog in PR [1836](https://github.com/microsoft/BotFramework-Emulator/pull/1836)

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -32,14 +32,15 @@
//

import * as React from 'react';
import { SmallHeader } from '@bfemulator/ui-react';

import * as styles from './welcomePage.scss';

export function HowToBuildABot() {
return (
<div className={styles.section}>
<div className={styles.howToBuildSection}>
<h3>How to build a bot</h3>
<SmallHeader className={styles.howToTitle}>How to build a bot</SmallHeader>
<div className={styles.stepContainer}>
<div className={styles.stepIcon}>
<div className={styles.buildPlan01} />
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -75,13 +75,8 @@
}

.how-to-build-section {
> h3 {
font-size: 13px;
font-weight: 600;
letter-spacing: 0.35px;
line-height: 16px;
margin: 0 0 24px 0;
text-transform: uppercase;
> .how-to-title {
margin: 18px 0 24px 0;
}

.step-container {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ export const well: string;
export const openBot: string;
export const ctaLink: string;
export const howToBuildSection: string;
export const howToTitle: string;
export const stepContainer: string;
export const stepIcon: string;
export const buildPlan01: string;
Expand Down
4 changes: 2 additions & 2 deletions packages/sdk/ui-react/src/widget/smallHeader/smallHeader.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ export interface SmallIHeaderProps {
}

export const SmallHeader = (props: SmallIHeaderProps): JSX.Element => (
<h3 className={`${styles.smallHeader} ${props.className || ''}`}>
<h2 className={`${styles.smallHeader} ${props.className || ''}`}>
<TruncateText>{props.children}</TruncateText>
</h3>
</h2>
);