Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom user ID validation should no longer show when disabled. #1946

Merged
merged 2 commits into from Nov 5, 2019

Conversation

@tonyanziano
Copy link
Contributor

tonyanziano commented Oct 29, 2019

Before:

id-validation-before

After:
image

image

@tonyanziano tonyanziano force-pushed the toanzian/id-validation branch from 1378c73 to 7bec04d Oct 29, 2019
@coveralls

This comment has been minimized.

Copy link

coveralls commented Oct 29, 2019

Coverage Status

Coverage decreased (-0.002%) to 67.087% when pulling c54da79 on toanzian/id-validation into 0a0990e on master.

@tonyanziano tonyanziano force-pushed the toanzian/id-validation branch from 7bec04d to c54da79 Nov 1, 2019
@tonyanziano tonyanziano changed the title [DON'T MERGE] Custom user ID validation should no longer show when disabled. Custom user ID validation should no longer show when disabled. Nov 1, 2019
Copy link
Member

corinagum left a comment

(^-^)

@tonyanziano tonyanziano merged commit 9c4a6ce into master Nov 5, 2019
2 checks passed
2 checks passed
Emulator-CI-PR #88452 succeeded
Details
license/cla All CLA requirements met.
Details
@tonyanziano tonyanziano deleted the toanzian/id-validation branch Nov 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.