Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sample: custom activity UI to select activity #1117

Closed
3 of 5 tasks
compulim opened this issue Aug 29, 2018 · 1 comment · Fixed by #1624
Closed
3 of 5 tasks

Sample: custom activity UI to select activity #1117

compulim opened this issue Aug 29, 2018 · 1 comment · Fixed by #1624
Assignees
@a-b-r-o-w-n
Labels
front-burner p0 Must Fix. Release-blocker Sample Implement PoC or sample code size-m 1-3 days
Projects
(Deprecated) Ignite: Others 4.3 Prioritization
Milestone
v4.3

Comments

@compulim
Copy link
Contributor

compulim commented Aug 29, 2018 •
edited by a-b-r-o-w-n

Working in PR #1199

  • Programmatically select an activity
  • Click to select an activity
  • Highlight after selection
  • Accessibility
  • If activity can be selected programmatically, will be nice to scroll the activity into view on select

This will be done as part of the emulator customization story, not on main branch.
@compulim compulim added the story label Aug 29, 2018
@compulim compulim self-assigned this Aug 29, 2018
@compulim compulim added this to To do in (Deprecated) Ignite: Others via automation Aug 29, 2018
@compulim compulim added Sample Implement PoC or sample code 4.2 front-burner and removed Story labels Oct 30, 2018
@compulim compulim added this to the v4.2 milestone Oct 30, 2018
@compulim compulim changed the title Web Chat Parity: Select activity Sample: custom activity UI to select activity Oct 30, 2018
@compulim compulim modified the milestone: v4.2 Oct 30, 2018
@sgellock sgellock added 4.3 and removed 4.2 labels Nov 27, 2018
@compulim compulim modified the milestones: v4.2, v4.3 Nov 28, 2018
@compulim compulim added the size-m 1-3 days label Dec 8, 2018
@compulim compulim added the p1 Painful if we don't fix, won't block releasing label Dec 18, 2018
@compulim compulim modified the milestone: v4.3 Dec 18, 2018
@compulim compulim removed their assignment Dec 18, 2018
@compulim compulim mentioned this issue Dec 18, 2018
Closed
1 task
@compulim compulim added p0 Must Fix. Release-blocker needs-design-input UX/UI design item and removed p1 Painful if we don't fix, won't block releasing labels Dec 18, 2018
@compulim compulim moved this from P1 to P0 in 4.3 Prioritization Dec 18, 2018
@a-b-r-o-w-n a-b-r-o-w-n self-assigned this Jan 7, 2019
@a-b-r-o-w-n a-b-r-o-w-n moved this from P0 to In-Flight in 4.3 Prioritization Jan 7, 2019
a-b-r-o-w-n added a commit that referenced this issue Jan 22, 2019
@a-b-r-o-w-n
add selectable activity sample
df577a5 
closes #1117
@a-b-r-o-w-n a-b-r-o-w-n mentioned this issue Jan 22, 2019
Merged
1 task
a-b-r-o-w-n added a commit that referenced this issue Jan 22, 2019
@a-b-r-o-w-n
add selectable activity sample
528ddda 
closes #1117
@a-b-r-o-w-n
Copy link
Contributor

@compulim I think adding the programatic selection of activities is a little out of scope for this sample. It is not too difficult to extrapolate from the redux sample how one might do that.

@corinagum corinagum removed the needs-design-input UX/UI design item label Jan 23, 2019
@corinagum corinagum mentioned this issue Jan 23, 2019
Closed
2 tasks
4.3 Prioritization automation moved this from In-Flight to Done Jan 23, 2019
corinagum pushed a commit that referenced this issue Jan 23, 2019
@a-b-r-o-w-n
add selectable activity sample (#1624)
54d0356 
* add selectable activity sample

closes #1117

* update changelog

* add a11y

* update readme
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@a-b-r-o-w-n a-b-r-o-w-n

Labels
front-burner p0 Must Fix. Release-blocker Sample Implement PoC or sample code size-m 1-3 days
Projects
No open projects
(Deprecated) Ignite: Others
  
To do
4.3 Prioritization
  
Done
Milestone
v4.3
Development

Successfully merging a pull request may close this issue.

add selectable activity sample microsoft/BotFramework-WebChat
5 participants
@sgellock @compulim @a-b-r-o-w-n @corinagum @DesignPolice