Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add selectable activity sample #1624

Merged
merged 4 commits into from
Jan 23, 2019
Merged

add selectable activity sample #1624

merged 4 commits into from
Jan 23, 2019

Conversation

a-b-r-o-w-n
Copy link
Contributor

@a-b-r-o-w-n a-b-r-o-w-n commented Jan 22, 2019

closes #1117

TODO:

  • a11y

@coveralls
Copy link

coveralls commented Jan 22, 2019

Pull Request Test Coverage Report for Build 820

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.04%) to 47.287%

Totals Coverage Status
Change from base Build 811: -0.04%
Covered Lines: 785
Relevant Lines: 1496

💛 - Coveralls

@corinagum
Copy link
Contributor

Do we want to include a11y in this PR, as well as selecting an activity programmatically? If not, we shouldn't close #1117 or file a new bug. :)

@a-b-r-o-w-n
Copy link
Contributor Author

Do we want to include a11y in this PR, as well as selecting an activity programmatically? If not, we shouldn't close #1117 or file a new bug. :)

I'm not sure the programatic selection makes sense (there is another example showing integration with the redux store) which can be expanded to add the programatic selection. I am working on a11y now. I'll push up a new commit shortly.

@corinagum
Copy link
Contributor

Created #1632 for discussion / tracking for a sample of programmatically selectable activities.

@corinagum corinagum merged commit 54d0356 into master Jan 23, 2019
@a-b-r-o-w-n a-b-r-o-w-n deleted the select-activity branch January 24, 2019 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sample: custom activity UI to select activity
3 participants