Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add visual regression test and code coverage report #1323

Merged
merged 23 commits into from
Nov 8, 2018

Conversation

compulim
Copy link
Contributor

@compulim compulim commented Nov 8, 2018

Added

  • Development build now include instrumentation code, updated build scripts
    • npm run build will build for development with instrumentation code
    • npm run prepublishOnly will build for production
    • npm run watch will also run Webpack in watch loop
  • Automated testing using visual regression testing technique

@compulim compulim added 4.2 p1 Painful if we don't fix, won't block releasing labels Nov 8, 2018
@compulim compulim added this to the v4.2 milestone Nov 8, 2018
@compulim
Copy link
Contributor Author

compulim commented Nov 8, 2018

Self-approving non-production code.

@compulim compulim merged commit 80a3a57 into microsoft:master Nov 8, 2018
@compulim compulim deleted the feat-test branch November 8, 2018 03:27
@compulim compulim removed this from the v4.2 milestone Nov 9, 2018
@compulim compulim added this to the v4.2 milestone Nov 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p1 Painful if we don't fix, won't block releasing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant