-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update ACHostConfig to use accessible TextBlock colors #3853
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few things:
- Please run
npm install
. The screenshot generated are from AC 2.5.0, but not the latest AC 2.9.0 - This file is not needed, probably generated because of earlier test failure:
__tests__/__image_snapshots__/html/transcript-activity-grouping-js-transcript-with-activity-grouping-test-50-2-snap.png
@compulim I'm running locally again to check, but this was most likely transient. I mistakenly added a command to the help command on MB that we don't want there, and then immediately removed it. I see it only failed once yesterday, around the time I made that push. The new messages button test only failed once, and the other repeating fails are timeout errors. I'll report back once I run tests locally again, but I expect them all to pass. |
Changelog Entry
adaptiveCardHostConfig
to accessible text color-contrasts, by @corinagum in PR #XXXDescription
This updates the host config to use contrast-compliant colors.
I used colors from Fabric UI color scheme to match MSFT colors.
CHANGELOG.md
I have updated documentationReview Checklist
z-index
)package.json
andpackage-lock.json
reviewed