Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HIGH] Bump to 4.15.5-0 with most latest deps #4423

Merged
merged 4 commits into from Sep 27, 2022

Conversation

compulim
Copy link
Contributor

@compulim compulim commented Sep 26, 2022

Related #4415.

Changelog Entry

Changed

Description

After release of 4.15.4, bump version to 4.15.5-0 with most latest deps.

Some deps, such as Adaptive Cards, Speech SDK, etc, are not bumped in this pull request. They will be bumped in another pull request.

Specific Changes

  • Updated package.json with an updated skipBump field that
    • Denote reasons why we are not bumping specific deps, we should revisit these reasons from time to time
    • Added --legacy-peer-deps to match lerna.json
      • This is because globalize-compiler requires cldr-data@>=25 which CANNOT be satisfy by cldr-data@36.0.0-0 (pre-release tag cannot satisfy version range)
  • Run npm bump on all packages
    • Most Jest and its deps cannot be upgraded to jest@29 as jest-image-snapshot@5.2.0 does not support it yet
  • Fix issues reported by TypeScript 4.8
  • Fixed test-page-object/package.json to use local peer version of botframework-webchat-core (for isForbiddenPropertyName)
  • I have added tests and executed them locally
  • I have updated CHANGELOG.md
  • I have updated documentation

Review Checklist

This section is for contributors to review your work.

  • Accessibility reviewed (tab order, content readability, alt text, color contrast)
  • Browser and platform compatibilities reviewed
  • CSS styles reviewed (minimal rules, no z-index)
  • Documents reviewed (docs, samples, live demo)
  • Internationalization reviewed (strings, unit formatting)
  • package.json and package-lock.json reviewed
  • Security reviewed (no data URIs, check for nonce leak)
  • Tests reviewed (coverage, legitimacy)

@compulim compulim reopened this Sep 26, 2022
@compulim compulim mentioned this pull request Sep 26, 2022
76 tasks
@compulim compulim marked this pull request as ready for review September 26, 2022 23:53
@compulim compulim changed the title Bump to 4.15.5-0 with most latest deps [HIGH] Bump to 4.15.5-0 with most latest deps Sep 27, 2022
@compulim compulim mentioned this pull request Sep 27, 2022
11 tasks
@compulim compulim merged commit f9dd67a into microsoft:main Sep 27, 2022
@compulim compulim deleted the bump-4.15.5-0 branch September 27, 2022 21:48
@compulim compulim mentioned this pull request Sep 28, 2022
11 tasks
@compulim compulim added the release Release checklist label Sep 28, 2022
@compulim compulim mentioned this pull request Dec 1, 2022
74 tasks
@compulim compulim mentioned this pull request Feb 15, 2023
76 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release Release checklist
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants