Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump to Speech SDK 1.23.0 #4435

Merged
merged 8 commits into from Oct 5, 2022
Merged

Conversation

compulim
Copy link
Contributor

@compulim compulim commented Sep 28, 2022

Related to #4415.

Changelog Entry

Changed

Description

Bump microsoft-cognitiveservices-speech-sdk@1.23.0 and web-speech-cognitive-services@7.1.2.

Design

Bumping web-speech-cognitive-services@7.1.2 can be found at compulim/web-speech-cognitive-services#196.

Importing from /distrib/lib/* vs. /distrib/es2015/*

When producing bundle, importing code from microsoft-cognitiveservices-speech-sdk/distrib/lib/* will yield smaller output size (30.5 MB) than from /distrib/es2015/* (39.5 MB).

This behavior is not well understood. However, we are keeping our current webpack.config.js and continue to import from /distrib/lib/ instead.

Sample code from /distrib/lib/src/common/Exports.js

Object.defineProperty(exports, "__esModule", { value: true });
__exportStar(require("./AudioSourceEvents"), exports);
__exportStar(require("./ConnectionEvents"), exports);

image

Sample code from /distrib/es2015/src/common/Exports.js

export * from "./AudioSourceEvents";
export * from "./ConnectionEvents";

image

Specific Changes

  • Update createMicrophoneAudioConfigAndAudioContext.ts to match updated API from Speech SDK

Bump microsoft-cognitiveservices-speech-sdk@1.23.0

npx lerna add microsoft-cognitiveservices-speech-sdk@1.23.0
  --exact
  --scope=botframework-directlinespeech-sdk
  --scope=botframework-webchat
  --scope=test-page-object

Bump web-speech-cognitive-services@7.1.2

npx lerna add web-speech-cognitive-services@7.1.2
  --exact
  --scope=botframework-directlinespeech-sdk
  --scope=botframework-webchat
  • I have added tests and executed them locally
  • I have updated CHANGELOG.md
  • I have updated documentation

Review Checklist

This section is for contributors to review your work.

  • Accessibility reviewed (tab order, content readability, alt text, color contrast)
  • Browser and platform compatibilities reviewed
  • CSS styles reviewed (minimal rules, no z-index)
  • Documents reviewed (docs, samples, live demo)
  • Internationalization reviewed (strings, unit formatting)
  • package.json and package-lock.json reviewed
  • Security reviewed (no data URIs, check for nonce leak)
  • Tests reviewed (coverage, legitimacy)

@compulim compulim added the release Release checklist label Sep 28, 2022
@compulim compulim marked this pull request as ready for review September 30, 2022 20:24
@compulim compulim merged commit d4c4aad into microsoft:main Oct 5, 2022
@compulim compulim deleted the bump-speech-sdk-1.23.0 branch October 5, 2022 17:32
@compulim compulim mentioned this pull request Jan 18, 2023
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release Release checklist
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants