Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Adaptive Cards to 3.0.2 #5115

Merged
merged 10 commits into from Apr 1, 2024
Merged

Bump Adaptive Cards to 3.0.2 #5115

merged 10 commits into from Apr 1, 2024

Conversation

compulim
Copy link
Contributor

@compulim compulim commented Mar 30, 2024

Changelog Entry

Changed

Description

Bump Adaptive Cards JS SDK to 3.0.2 to support Adaptive Cards.

However, AC JS SDK requires swiper but they forget to include it as their production dependencies. We are adding swiper@^8.2.6 to workaround their issue.

Design

Some features in Adaptive Cards are in preview or designed to use outside of Bot Framework. Web Chat does not support these features.

One notable example is "dynamic typeahead" feature in Adaptive Cards. This feature is not localized and strings are hardcoded in their source code. Web Chat does not support "dynamic typeahead".

Web Chat does not support universal action model (a.k.a. Action.Execute). This is because our chat adapter does not support invoke activity. Changes would need to be made in the chat adapter before Web Chat can support Action.Execute.

Specific Changes

  • Bumped adaptivecards@3.0.2
  • Added tests to verify our hacks
  • Removed an obsoleted hack, the fix is deployed in Adaptive Cards JS SDK
  • I have added tests and executed them locally
  • I have updated CHANGELOG.md
  • I have updated documentation

Review Checklist

This section is for contributors to review your work.

  • Accessibility reviewed (tab order, content readability, alt text, color contrast)
  • Browser and platform compatibilities reviewed
  • CSS styles reviewed (minimal rules, no z-index)
  • Documents reviewed (docs, samples, live demo)
  • Internationalization reviewed (strings, unit formatting)
  • package.json and package-lock.json reviewed
  • Security reviewed (no data URIs, check for nonce leak)
  • Tests reviewed (coverage, legitimacy)

@compulim compulim marked this pull request as ready for review March 30, 2024 17:35
@compulim compulim merged commit 512cc60 into main Apr 1, 2024
27 of 31 checks passed
@compulim compulim deleted the bump-ac branch April 1, 2024 21:32
@Luckymhe
Copy link

Luckymhe commented Apr 2, 2024

Yml is no longer working its gone .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants