Bump webpack and remove event-target-shim #5156
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog Entry
Known issues
Uncaught TypeError: Super constructor null of anonymous class is not a constructor
webpack@>=5.90.0
Fixed
webpack@5.91.0
, in PR #5156, by @compulimChanged
webpack@5.91.0
Description
webpack@5.84.1
has a bug that markedevent-target-shim
to be "unused pure superclass". We are onwebpack@5.89.0
and is experiencing the bug.Our recent ESM work (#5148) emits minified code in our package tarball and expose the issue in Webpack. For example:
Webpack will re-emit it as following and marked the
XYZ
superclass as "unused pure":Despite our E2E tests use CDN bundle, we did not catch this issue in PR validation because it will only repro on production build. In other words, it only repro on
NODE_ENV=production npm run build
.Design
While we are working on the issue, we thought it was related to
event-target-shim
. Since we dropped IE11 support, we no longer need majority functionality ofevent-target-shim
, we replaced it with our owncreateOnEventShim
.We continue to keep this replacement work as it will reduce our bundle size.
Specific Changes
webpack@5.91.0
event-target-shim
and replaced withcreateOnEventShim
CHANGELOG.md
I have updated documentationReview Checklist
Accessibility reviewed (tab order, content readability, alt text, color contrast)Browser and platform compatibilities reviewedCSS styles reviewed (minimal rules, noz-index
)Documents reviewed (docs, samples, live demo)Internationalization reviewed (strings, unit formatting)package.json
andpackage-lock.json
reviewedSecurity reviewed (no data URIs, check for nonce leak)Tests reviewed (coverage, legitimacy)