Add candidate_viability scenario
#5935
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ails trace validation
achamayou
approved these changes
Jan 18, 2024
heidihoward
approved these changes
Jan 18, 2024
|
candidate_viability_scenario@81980 aka 20240219.15 vs main ewma over 20 builds from 81610 to 81973 Click to see tablemain
candidate_viability_scenario
|
…CCF into candidate_viability_scenario
eddyashton
commented
Jan 22, 2024
…CCF into candidate_viability_scenario
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ends up being another flavour of
suffix_collision, but naming it ascandidate_viabilityto capture the original intent/investigation.This acts as a regression scenario for the spec issue spotted in #5934. This is a scenario which we believe is valid, and can trace match, but for which
MoreUpToDateCorrectInvis not an invariant.This adds a few new driver actions:
dispatch_single,{src},{dst}lets us examine the state after single messages at the scenario level. Previously we could only flush at the node-to-node level message.summarise_log(s_all)prints the log state. Primarily for debugging, similar tostate.