-
Notifications
You must be signed in to change notification settings - Fork 208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Attempt to fix the simulation #5939
Merged
achamayou
merged 5 commits into
microsoft:main
from
achamayou:relax_simulation_invariants
Jan 19, 2024
Merged
Attempt to fix the simulation #5939
achamayou
merged 5 commits into
microsoft:main
from
achamayou:relax_simulation_invariants
Jan 19, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lemmy
reviewed
Jan 18, 2024
relax_simulation_invariants@80551 aka 20240119.5 vs main ewma over 16 builds from 80229 to 80541 Click to see tablemain
relax_simulation_invariants
|
eddyashton
approved these changes
Jan 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With #5922, the simulation has much better coverage, and is now hitting invariants that are not clearly useful as we try to reconcile the impl and the spec. This is an attempt to drop enough to get back to a working CI without making unreasonable changes.