-
Notifications
You must be signed in to change notification settings - Fork 206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Basic consistency TV app and client #6116
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eddyashton
approved these changes
Apr 9, 2024
basic_tv_app_and_client@83559 aka 20240411.7 vs main ewma over 20 builds from 83291 to 83548 Click to see tablemain
basic_tv_app_and_client
|
This was referenced Apr 12, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successor to #5727, but aimed at trace validating the consistency spec. This adds:
consistency_trace.ndjson
:Samples extract, to reproduce locally, run
./tests.sh -VV -R consistency_trace_validation
:It's also possible to run the tvc against a manually started sandbox, as described in the docstring.
This should already be usable for trace validation as is, but a good additional change would be to use the partition module to cause more failed transactions than can be done with the lengthened signature period. This will require some CI changes to run as part of the partition test (i.e. elevated).