New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Full command forwarding #75
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
achamayou
approved these changes
May 17, 2019
achamayou
approved these changes
May 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces support for full RPC forwarding if a
Write
command is issued on a follower.Changes
rpcendpoint.h
, the rpc response is no longer synchronously written to the session if the command requires forwarding. Instead, nothing is written to the session (i.e. the session stays open) until the forwarded response comes back from the leader.Forwarder
object that is only known byenclave.h
and the frontends that are allowed to forward (only theUSERS
one for now) and that deals with the appending/reading the appropriate headers to the message before being sent/received (encrypted).RPC_FORWARD_TO_LEADER
is gone as forwarding is now enabled by default.Notes
e2e_logging
ande2e_scenarios
tests.Still to do