Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix VS2015 crash when all installed SDKs are higher than 10.0.14393 #69

Merged
merged 1 commit into from
Nov 27, 2018

Conversation

jgoshi
Copy link
Member

@jgoshi jgoshi commented Nov 27, 2018

This is a fix in our fork for the upstream 3.13 regression which will be fixed in 3.13.1. Here is the original issue and merge request into upstream cmake.
https://gitlab.kitware.com/cmake/cmake/issues/18633
https://gitlab.kitware.com/cmake/cmake/merge_requests/2656

Copy link

@khouzam khouzam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the proper fix.
Sorry, I introduced the bug.

@jgoshi jgoshi merged commit 6c4f04a into cmake-daemon Nov 27, 2018
@jgoshi jgoshi deleted the dev/jgoshi/vs2015GeneratorCrash branch November 27, 2018 00:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants