Skip to content
This repository has been archived by the owner on Jul 15, 2023. It is now read-only.

Fix for generic type parameters used as constraints for another type parameter. #55

Closed
wants to merge 2 commits into from

Conversation

hubuk
Copy link
Contributor

@hubuk hubuk commented May 26, 2015

This should fix #20.

@hubuk hubuk changed the title Fix for generic type parameters used as constraints for another type parameters. Fix for generic type parameters used as constraints for another type parameter. May 27, 2015
TypeNodeList savedTypes = this.currentTypeParameters;
this.currentTypeParameters = types;
try
{
int i = 0, n = genericParameters.Length, j = n-1;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Can you correct just the indentation for the contents of the block? In other words, add two spaces at the beginning of each line but don't change any other formatting associated with the block.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rebracer may be a nice solution for keeping formatting for the project the same for everybody, works well for me at work.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have some doubts about using that (especially considering I'm working on an alternative that doesn't require Visual Studio), but either way it would be a separate issue to consider from this pull request.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This whole file needs a reformatting as it uses two space indentation.

@sharwell
Copy link
Member

@hubuk Where would a regression test for this be added?

@SergeyTeplyakov
Copy link
Contributor

@hubuk could you rebase with master head, please?

And could you please at specify the test case when this issue is happening? I'll add tests myself..

@SergeyTeplyakov
Copy link
Contributor

Close as dup. Merged #95

@hubuk hubuk deleted the issue20 branch July 30, 2015 22:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to cast object of type 'System.Compiler.TypeParameter' to type 'System.Compiler.Class'.
4 participants