This repository has been archived by the owner on Nov 16, 2023. It is now read-only.
Add noUnusedLocals: true to tsconfig.
#127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
First step in getting more of the TypeScript compiler checks on to help prevent bugs. This flag is more aesthetics than behavioral; however, it does help debugging and navigating code when looking up references. Since so many of the models and actions were imported into classes and not used it made it appear that they were used by more classes. I did see a few issues around using Redux `connect` and microsoft/TypeScript#5938 It's related to trying to export Props which contains types from the Models class that were not explicitly imported. I believe this is because we are using the `returntypeof` instead of explicitly defining the interfaces. I noticed `connect` has generic overload <StateProps, DispatchProps, OwnProps> and it internally merges them all which is what I think we should be doing; however, currently don't have well established pattern so I left code as is.
|
@mattmazzola, |
|
Hmm, I noticed those issue i referenced is actually related to trying to output declaration files. For some reason we have, |
|
Wasn't aware of this flag. Very cool. |
|
@mattmazzola, |
LarsLiden
approved these changes
Sep 21, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First step in getting more of the TypeScript compiler checks on to help prevent bugs. This flag is more aesthetics than behavioral; however, it does help debugging and navigating code when looking up references. Since so many of the models and actions were imported into classes and not used it made it appear that they were used by more classes.
I did see a few issues around using Redux
connectand microsoft/TypeScript#5938It's related to trying to export Props which contains types from the Models class that were not explicitly imported.
I believe this is because we are using the
returntypeofinstead of explicitly defining the interfaces.I noticed
connecthas generic overload <StateProps, DispatchProps, OwnProps> and it internally merges them all which is what I think we should be doing; however, currently don't have well established pattern so I left code as is.I think we should be able to handle this; however, I agree it shouldn't be strict blocker as there are some known weirdness with TypeScript / Redux. If there are major issues we can temporarily revert the flag back.