Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge20231204 #249

Merged
merged 2 commits into from
Dec 5, 2023
Merged

Merge20231204 #249

merged 2 commits into from
Dec 5, 2023

Conversation

samtertzakian
Copy link
Member

@samtertzakian samtertzakian commented Dec 4, 2023

Merge20231204

  1. Add support to DMF_IoctHandler to allow multiple instances of the same IOCTL table to be attached to same WDFDEVICE. It allows two instances of a Parent module that has DMF_IoctlHanlder as a Child Module to be instantiated in the same driver such that ReferenceSring is used to route WDFREQUEST to the proper instance.
  2. Fix Verifier issue in DMF_NotifyUserWithRequestMultiple relaated to untagged dereference.
  3. Fix some SAL issues.
  4. Add DMF_ConnectedStandby Module.

1. Add support to DMF_IoctHandler to allow multiple instances of the same IOCTL table to be attached to same WDFDEVICE. It allows two instances of a Parent module that has DMF_IoctlHanlder as a Child Module to be instantiated in the same driver such that ReferenceSring is used to route WDFREQUEST to the proper instance.
2. Fix Verifier issue in DMF_NotifyUserWithRequestMultiple relaated to untagged dereference.
3. Fix some SAL issues.
4. Add DMF_ConnectedStandyby Module.
#pragma code_seg("PAGE")
NTSTATUS
ConnectedStandby_OnConnectedStandby(
LPCGUID SettingGuid,
Copy link
Member

@ankurung ankurung Dec 4, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SAL annotations missing

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed


-----------------------------------------------------------------------------------------------------------------------------------

This Module allows the Client to request and receive notifications when the system has entered or exited Connected Standby.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Windows 10 Modern Standby (Modern Standby) expands the Windows 8.1 Connected Standby power model

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

FuncEntry(DMF_TRACE);

moduleContext = DMF_CONTEXT_GET(DmfModule);

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove the extra blank lines..

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed


FuncEntry(DMF_TRACE);

ntStatus = STATUS_SUCCESS;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unnecessary.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@samtertzakian samtertzakian merged commit c472024 into master Dec 5, 2023
1 check passed
@samtertzakian samtertzakian deleted the Merge20231204 branch February 8, 2024 01:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants