Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Silence comm.py warning #3893

Merged
merged 2 commits into from
Jul 6, 2023
Merged

Silence comm.py warning #3893

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f915a9e
avoid init for deepspeed backend first
mrwyattii Jul 6, 2023
2e20414
Merge branch 'master' into mrwyattii/silence-comm-warning
loadams Jul 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 8 additions & 7 deletions deepspeed/comm/comm.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -606,13 +606,14 @@ def init_distributed(dist_backend=None,
dist_init_required = cdb is None or not cdb.is_initialized()

if cdb is None:
init_deepspeed_backend(get_accelerator().communication_backend_name(), timeout, init_method)
set_backend()
utils.logger.info(f'cdb={cdb}')
if cdb is None and torch.distributed.is_initialized():
# The user initialized torch.dist themselves, create cdb and short-circuit
cdb = TorchBackend(dist_backend, timeout, init_method)
return
if torch.distributed.is_initialized():
# The user initialized torch.dist themselves, create cdb and short-circuit
cdb = TorchBackend(dist_backend, timeout, init_method)
return
else:
init_deepspeed_backend(get_accelerator().communication_backend_name(), timeout, init_method)
set_backend()
utils.logger.info(f'cdb={cdb}')

if dist_init_required is False:
assert (
Expand Down