Added __HIP_PLATFORM_AMD__=1 for non JIT build #4585
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rraminen
requested review from
jeffra,
RezaYazdaniAminabadi and
cmikeh2
as code owners
loadams
approved these changes
Oct 31, 2023
loadams
reviewed
Oct 31, 2023
| @@ -614,6 +614,9 @@ def builder(self): | |||
| if not self.build_for_cpu and self.enable_bf16: | |||
| compile_args['cxx'].append("-DBF16_AVAILABLE") | |||
|
|
|||
| if self.is_rocm_pytorch(): | |||
|
The PR failure is not due to changes here, and we will get this merged as we get that other issue solved. |
|
Hi @loadams, is this PR ready to be merged? Thanks. |
Yes, we've identified a CI issue that's unrelated we are trying to fix, will have this merged right after that. |
mauryaavinash95
pushed a commit
to mauryaavinash95/DeepSpeed
that referenced
this pull request
Feb 17, 2024
This PR is required in addition to microsoft#4539 to define HIP_PLATFORM_AMD on ROCm. This is required for DeepSpeed non-JIT build. For JIT build we have microsoft#4570. This is required for DeepSpeed extensions build in those docker images with PyTorch built before pytorch/pytorch#111975. cc: @jeffdaily @jithunnair-amd Co-authored-by: Logan Adams <114770087+loadams@users.noreply.github.com>
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is required in addition to #4539 to define HIP_PLATFORM_AMD on ROCm.
This is required for DeepSpeed non-JIT build. For JIT build we have #4570.
This is required for DeepSpeed extensions build in those docker images with PyTorch built before pytorch/pytorch#111975.
cc: @jeffdaily @jithunnair-amd