[ROCm] remove HCC references #111975
Closed
[ROCm] remove HCC references #111975
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- rename `__HIP_PLATFORM_HCC__` to `__HIP_PLATFORM_AMD__` - rename `HIP_HCC_FLAGS` to `HIP_CLANG_FLAGS` - rename `PYTORCH_HIP_HCC_LIBRARIES` to `PYTORCH_HIP_LIBRARIES` - workaround in tools/amd_build/build_amd.py until submodules are updated These symbols have had a long deprecation cycle and will finally be removed in ROCm 6.0.
jeffdaily
requested review from
jithunnair-amd,
fmassa,
soumith and
ezyang
as code owners
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/111975
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit a502e87 with merge base b600aed ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
ezyang
approved these changes
Oct 25, 2023
ezyang
added
release notes: rocm
|
lint |
hongxiayang
reviewed
Oct 25, 2023
hongxiayang
approved these changes
Oct 25, 2023
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
andreigh
pushed a commit
to andreigh/pytorch
that referenced
this pull request
Oct 26, 2023
- rename `__HIP_PLATFORM_HCC__` to `__HIP_PLATFORM_AMD__` - rename `HIP_HCC_FLAGS` to `HIP_CLANG_FLAGS` - rename `PYTORCH_HIP_HCC_LIBRARIES` to `PYTORCH_HIP_LIBRARIES` - workaround in tools/amd_build/build_amd.py until submodules are updated These symbols have had a long deprecation cycle and will finally be removed in ROCm 6.0. Pull Request resolved: pytorch#111975 Approved by: https://github.com/ezyang, https://github.com/hongxiayang
xuhancn
pushed a commit
to xuhancn/pytorch
that referenced
this pull request
Nov 7, 2023
- rename `__HIP_PLATFORM_HCC__` to `__HIP_PLATFORM_AMD__` - rename `HIP_HCC_FLAGS` to `HIP_CLANG_FLAGS` - rename `PYTORCH_HIP_HCC_LIBRARIES` to `PYTORCH_HIP_LIBRARIES` - workaround in tools/amd_build/build_amd.py until submodules are updated These symbols have had a long deprecation cycle and will finally be removed in ROCm 6.0. Pull Request resolved: pytorch#111975 Approved by: https://github.com/ezyang, https://github.com/hongxiayang
github-merge-queue bot
pushed a commit
to microsoft/DeepSpeed
that referenced
this pull request
Nov 8, 2023
This PR is required in addition to #4539 to define HIP_PLATFORM_AMD on ROCm. This is required for DeepSpeed non-JIT build. For JIT build we have #4570. This is required for DeepSpeed extensions build in those docker images with PyTorch built before pytorch/pytorch#111975. cc: @jeffdaily @jithunnair-amd Co-authored-by: Logan Adams <114770087+loadams@users.noreply.github.com>
This was referenced Nov 9, 2023
Skylion007
pushed a commit
to Skylion007/pytorch
that referenced
this pull request
Nov 14, 2023
- rename `__HIP_PLATFORM_HCC__` to `__HIP_PLATFORM_AMD__` - rename `HIP_HCC_FLAGS` to `HIP_CLANG_FLAGS` - rename `PYTORCH_HIP_HCC_LIBRARIES` to `PYTORCH_HIP_LIBRARIES` - workaround in tools/amd_build/build_amd.py until submodules are updated These symbols have had a long deprecation cycle and will finally be removed in ROCm 6.0. Pull Request resolved: pytorch#111975 Approved by: https://github.com/ezyang, https://github.com/hongxiayang
lubosz
pushed a commit
to lubosz/pytorch
that referenced
this pull request
Jan 4, 2024
- rename `__HIP_PLATFORM_HCC__` to `__HIP_PLATFORM_AMD__` - rename `HIP_HCC_FLAGS` to `HIP_CLANG_FLAGS` - rename `PYTORCH_HIP_HCC_LIBRARIES` to `PYTORCH_HIP_LIBRARIES` - workaround in tools/amd_build/build_amd.py until submodules are updated These symbols have had a long deprecation cycle and will finally be removed in ROCm 6.0. Pull Request resolved: pytorch#111975 Approved by: https://github.com/ezyang, https://github.com/hongxiayang
mauryaavinash95
pushed a commit
to mauryaavinash95/DeepSpeed
that referenced
this pull request
Feb 17, 2024
This PR is required in addition to microsoft#4539 to define HIP_PLATFORM_AMD on ROCm. This is required for DeepSpeed non-JIT build. For JIT build we have microsoft#4570. This is required for DeepSpeed extensions build in those docker images with PyTorch built before pytorch/pytorch#111975. cc: @jeffdaily @jithunnair-amd Co-authored-by: Logan Adams <114770087+loadams@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
__HIP_PLATFORM_HCC__to__HIP_PLATFORM_AMD__HIP_HCC_FLAGStoHIP_CLANG_FLAGSPYTORCH_HIP_HCC_LIBRARIEStoPYTORCH_HIP_LIBRARIESThese symbols have had a long deprecation cycle and will finally be removed in ROCm 6.0.
cc @sunway513 @jithunnair-amd @pruthvistony @ROCmSupport @dllehr-amd @jataylo @hongxiayang