Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix num_kv_heads sharding in autoTP for the new in-repo Falcon-40B #4654

Merged
merged 3 commits into from
Nov 10, 2023
Merged

fix num_kv_heads sharding in autoTP for the new in-repo Falcon-40B #4654

merged 3 commits into from
Nov 10, 2023

Conversation

dc3671
Copy link
Contributor

@dc3671 dc3671 commented Nov 8, 2023

to be compatible with the latest Falcon-40B's num_kv_heads in https://huggingface.co/tiiuae/falcon-40b/commit/4a70170c215b36a3cce4b4253f6d0612bb7d4146
image

error message like:
image

@dc3671 dc3671 mentioned this pull request Nov 8, 2023
Open
1 task
@dc3671
Copy link
Contributor Author

dc3671 commented Nov 10, 2023

Hi @loadams . Can this be merged or need more review?

@loadams
Copy link
Contributor

loadams commented Nov 10, 2023

Hi @loadams . Can this be merged or need more review?

This should just need a review and can be merged

@loadams loadams added this pull request to the merge queue Nov 10, 2023
Merged via the queue into microsoft:master with commit 6ea44d0 Nov 10, 2023
15 checks passed
mauryaavinash95 pushed a commit to mauryaavinash95/DeepSpeed that referenced this pull request Feb 17, 2024
@dc3671 @loadams @lekurile
fix num_kv_heads sharding in autoTP for the new in-repo Falcon-40B (m…
abc4e6d 
…icrosoft#4654)

to be compatible with the latest Falcon-40B's `num_kv_heads` in
https://huggingface.co/tiiuae/falcon-40b/commit/4a70170c215b36a3cce4b4253f6d0612bb7d4146

![image](https://github.com/microsoft/DeepSpeed/assets/5948851/d20aa6f2-b9af-4104-b9d3-8ba1ab588a6e)

error message like:

![image](https://github.com/microsoft/DeepSpeed/assets/5948851/06ef6dd2-25d5-4b51-8789-36e1b3f94a32)

Co-authored-by: Logan Adams <114770087+loadams@users.noreply.github.com>
Co-authored-by: Lev Kurilenko <113481193+lekurile@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lekurile lekurile lekurile approved these changes

@RezaYazdaniAminabadi RezaYazdaniAminabadi Awaiting requested review from RezaYazdaniAminabadi

@jeffra jeffra Awaiting requested review from jeffra

@mrwyattii mrwyattii Awaiting requested review from mrwyattii

@awan-10 awan-10 Awaiting requested review from awan-10 awan-10 is a code owner

@cmikeh2 cmikeh2 Awaiting requested review from cmikeh2

@arashb arashb Awaiting requested review from arashb arashb is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dc3671 @loadams @lekurile