launcher/launcher_helper.py: fix PMI name and add EnvironmentError #5025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @mrwyattii, could you help to review this? Thanks! |
loadams
approved these changes
Jan 29, 2024
mauryaavinash95
pushed a commit
to mauryaavinash95/DeepSpeed
that referenced
this pull request
Feb 17, 2024
…icrosoft#5025) Hi, for my last PR microsoft#4699 about launcher_helper, it mistakenly used two "PMIX". In this PR I corrected them to be "PMIX" and "PMI". And I also added _EnvironmentError_ to make sure env not get _NONE_ type, otherwise it would trigger env setting error.
rraminen
pushed a commit
to ROCm/DeepSpeed
that referenced
this pull request
May 9, 2024
…icrosoft#5025) Hi, for my last PR microsoft#4699 about launcher_helper, it mistakenly used two "PMIX". In this PR I corrected them to be "PMIX" and "PMI". And I also added _EnvironmentError_ to make sure env not get _NONE_ type, otherwise it would trigger env setting error.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, for my last PR #4699 about launcher_helper, it mistakenly used two "PMIX". In this PR I corrected them to be "PMIX" and "PMI". And I also added EnvironmentError to make sure env not get NONE type, otherwise it would trigger env setting error.