Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

launcher/launcher_helper.py: fix PMI name and add EnvironmentError #5025

Merged
merged 1 commit into from Jan 29, 2024
Merged

launcher/launcher_helper.py: fix PMI name and add EnvironmentError #5025

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 5 additions & 1 deletion deepspeed/launcher/launcher_helper.py
View file
Open in desktop
Expand Up @@ -60,6 +60,8 @@ def env_mapping(env, rank_name_list=None, local_rank_name_list=None):
rank = env.get(rank_name)
elif rank != env.get(rank_name):
raise EnvironmentError(f"rank number doesn't match!")
if rank == None:
raise EnvironmentError(f"rank number is not in current env!")
env['RANK'] = rank

local_rank = None
Expand All @@ -69,6 +71,8 @@ def env_mapping(env, rank_name_list=None, local_rank_name_list=None):
local_rank = env.get(local_rank_name)
elif local_rank != env.get(local_rank_name):
raise EnvironmentError(f"local_rank number doesn't match!")
if local_rank == None:
raise EnvironmentError(f"rank number is not in current env!")
env['LOCAL_RANK'] = local_rank

return env
Expand All @@ -81,7 +85,7 @@ def main(args=None):

args.launcher = args.launcher.lower()
if args.launcher == MPICH_LAUNCHER:
rank_name_list = ["PMIX_RANK"] + ["PMIX_RANK"]
rank_name_list = ["PMIX_RANK"] + ["PMI_RANK"]
local_rank_name_list = ["PALS_LOCAL_RANKID"] + ["MPI_LOCALRANKID"]
env = env_mapping(env, rank_name_list=rank_name_list, local_rank_name_list=local_rank_name_list)
else:
Expand Down