Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore non-types packages returned by pnpm #803

Merged

Conversation

jakebailey
Copy link
Member

@jakebailey jakebailey commented Nov 1, 2023

This unblocks DefinitelyTyped/DefinitelyTyped#67259. See https://github.com/DefinitelyTyped/DefinitelyTyped/actions/runs/6708512678/job/18229483924?pr=67259

M	types/node/v18/ts4.8/test/stream.ts
AssertionError [ERR_ASSERTION]: bad path scripts
    at assertDefined (/home/runner/work/DefinitelyTyped/DefinitelyTyped/node_modules/.pnpm/@definitelytyped+utils@0.0.182/node_modules/@definitelytyped/utils/src/assertions.ts:7:9)
    at <anonymous> (/home/runner/work/DefinitelyTyped/DefinitelyTyped/node_modules/.pnpm/@definitelytyped+definitions-parser@0.0.186_typescript@5.3.0-dev.202[31](https://github.com/DefinitelyTyped/DefinitelyTyped/actions/runs/6708512678/job/18229483924?pr=67259#step:7:32)031/node_modules/@definitelytyped/definitions-parser/src/get-affected-packages.ts:99:30)
    at Array.map (<anonymous>)

This happens because I added a scripts package to the DT repo in DefinitelyTyped/DefinitelyTyped#67128 which depended on @types/node, but we didn't fully ignore non-@types packages (since such a thing didn't exist until now).

@jakebailey jakebailey merged commit 046ac38 into microsoft:master Nov 1, 2023
6 checks passed
@jakebailey jakebailey deleted the permissive-affected-packages branch November 1, 2023 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants