[node] Expose global ResponseInit; remove NodeJS.fetch namespace

[thw0rted]

Please fill in this template.

• Use a meaningful title for the pull request. Include the name of the package modified.
• Test the change in your own code. (Compile and run.)
• Add or edit tests to reflect the change.
• Follow the advice from the readme.
• Avoid common mistakes.
• Run pnpm test <package to test>.

Select one of these and delete the others:

If changing an existing definition:

• Provide a URL to documentation or source code which provides context for the suggested changes: https://fetch.spec.whatwg.org/
• If this PR brings the type definitions up to date with a new version of the JS library, update the version number in the header.

[typescript-bot]

@thw0rted Thank you for submitting this PR!

This is a live comment which I will keep updated.

1 package in this PR

• node — on npm, on unpkg

Code Reviews

Because this is a widely-used package, a DT maintainer will need to review it before it can be merged.

You can test the changes of this PR in the Playground.

Status

• ✅ No merge conflicts
• ✅ Continuous integration tests have passed
• ✅ Most recent commit is approved by a DT maintainer

All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes.

---

Diagnostic Information: What the bot saw about this PR

{
  "type": "info",
  "now": "-",
  "pr_number": 67341,
  "author": "thw0rted",
  "headCommitOid": "3884171509ea897c7411be2f8d23f81dd99c1c62",
  "mergeBaseOid": "9235592ccbfd67841f58d46f06ddef1306bd61e9",
  "lastPushDate": "2023-11-07T16:47:01.000Z",
  "lastActivityDate": "2023-12-01T19:42:37.000Z",
  "mergeOfferDate": "2023-11-30T23:51:14.000Z",
  "mergeRequestDate": "2023-12-01T19:42:37.000Z",
  "mergeRequestUser": "thw0rted",
  "hasMergeConflict": false,
  "isFirstContribution": false,
  "tooManyFiles": false,
  "hugeChange": false,
  "popularityLevel": "Critical",
  "pkgInfo": [
    {
      "name": "node",
      "kind": "edit",
      "files": [
        {
          "path": "types/node/globals.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/node/test/globals.ts",
          "kind": "test"
        },
        {
          "path": "types/node/ts4.8/globals.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/node/ts4.8/test/globals.ts",
          "kind": "test"
        },
        {
          "path": "types/node/v18/globals.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/node/v18/test/globals.ts",
          "kind": "test"
        },
        {
          "path": "types/node/v18/ts4.8/globals.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/node/v18/ts4.8/test/globals.ts",
          "kind": "test"
        }
      ],
      "owners": [
        "Microsoft",
        "jkomyno",
        "alvis",
        "r3nya",
        "btoueg",
        "smac89",
        "touffy",
        "DeividasBakanas",
        "eyqs",
        "Hannes-Magnusson-CK",
        "hoo29",
        "kjin",
        "ajafff",
        "islishude",
        "mwiktorczyk",
        "mohsen1",
        "n-e",
        "galkin",
        "parambirs",
        "eps1lon",
        "ThomasdenH",
        "WilcoBakker",
        "wwwy3y3",
        "samuela",
        "kuehlein",
        "bhongy",
        "chyzwar",
        "trivikr",
        "yoursunny",
        "qwelias",
        "ExE-Boss",
        "peterblazejewicz",
        "addaleax",
        "victorperin",
        "ZYSzys",
        "NodeJS",
        "LinusU",
        "wafuwafu13",
        "mcollina",
        "Semigradsky"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Critical"
    }
  ],
  "reviews": [
    {
      "type": "approved",
      "reviewer": "andrewbranch",
      "date": "2023-11-30T23:50:28.000Z",
      "isMaintainer": true
    },
    {
      "type": "stale",
      "reviewer": "jakebailey",
      "date": "2023-11-13T19:42:49.000Z",
      "abbrOid": "d0cd74c"
    },
    {
      "type": "stale",
      "reviewer": "RyanCavanaugh",
      "date": "2023-11-10T22:32:53.000Z",
      "abbrOid": "d0cd74c"
    }
  ],
  "mainBotCommentID": 1799183235,
  "ciResult": "pass"
}

[typescript-bot]

🔔 @microsoft @jkomyno @alvis @r3nya @btoueg @smac89 @Touffy @DeividasBakanas @eyqs @Hannes-Magnusson-CK @hoo29 @kjin @ajafff @islishude @mwiktorczyk @mohsen1 @n-e @galkin @parambirs @eps1lon @ThomasdenH @WilcoBakker @wwwy3y3 @samuela @kuehlein @bhongy @chyzwar @trivikr @yoursunny @qwelias @ExE-Boss @peterblazejewicz @addaleax @victorperin @ZYSzys @nodejs @LinusU @wafuwafu13 @mcollina @Semigradsky — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

[thw0rted]

This is really two changes and if anyone objects to either, I can split into separate PRs.

The first is to add the global ResponseInfo type, which was missing from the original PR #66824.

The second is to refactor out the NodeJS.fetch "fictional" namespace so that users don't start explicitly including the types there, including aliases that are only used as part of the conditional global definition gadget (typeof globalThis extends ...).

I updated tests but couldn't get test-all to run locally (microsoft/DefinitelyTyped-tools#816) and they're failing in CI.

ETA: figured out pnpm run test node/v18 which passes, whew.

[typescript-bot]

@thw0rted The CI build failed! Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

Note: builds which are failing do not end up on the list of PRs for the DT maintainers to review.

[thw0rted]

I'm not sure these CI failures are actually caused by my changes, see also #67259 and #67291.

Maybe @jakebailey or @andrewbranch can take a look? (Author and reviewer of microsoft/DefinitelyTyped-tools#803, respectively.)

[thw0rted]

New commit adds the missing global File type as well, since it winds up in some fetch sub-sub-types.

[jakebailey]

Weird es-abstract related failures are a problem due to our new partial package installs here; the latest dt-tools should fix this via some hack.

[typescript-bot]

@thw0rted The CI build failed! Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

Note: builds which are failing do not end up on the list of PRs for the DT maintainers to review.

[typescript-bot]

@thw0rted The CI build failed! Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

Note: builds which are failing do not end up on the list of PRs for the DT maintainers to review.

[jakebailey]

wat

[DangerBotOSS]

Formatting

The following files are not formatted:

1. types/node/globals.d.ts
2. types/node/v18/globals.d.ts
3. types/node/ts4.8/globals.d.ts
4. types/node/v18/ts4.8/globals.d.ts

Consider running pnpm dprint fmt on these files to make review easier.

Generated by 🚫 dangerJS against 3884171

[typescript-bot]

@RyanCavanaugh Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?

[typescript-bot]

@jakebailey, @RyanCavanaugh Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?

[typescript-bot]

Re-ping @microsoft, @jkomyno, @alvis, @r3nya, @btoueg, @smac89, @Touffy, @DeividasBakanas, @eyqs, @Hannes-Magnusson-CK, @hoo29, @kjin, @ajafff, @islishude, @mwiktorczyk, @mohsen1, @n-e, @galkin, @parambirs, @eps1lon, @ThomasdenH, @WilcoBakker, @wwwy3y3, @samuela, @kuehlein, @bhongy, @chyzwar, @trivikr, @yoursunny, @qwelias, @ExE-Boss, @peterblazejewicz, @addaleax, @victorperin, @ZYSzys, @nodejs, @LinusU, @wafuwafu13, @mcollina, @Semigradsky:

This PR has been out for over a week, yet I haven't seen any reviews.

Could someone please give it some attention? Thanks!

[typescript-bot]

It has been more than two weeks and this PR still has no reviews.

I'll bump it to the DT maintainer queue. Thank you for your patience, @thw0rted.

(Ping @microsoft, @jkomyno, @alvis, @r3nya, @btoueg, @smac89, @Touffy, @DeividasBakanas, @eyqs, @Hannes-Magnusson-CK, @hoo29, @kjin, @ajafff, @islishude, @mwiktorczyk, @mohsen1, @n-e, @galkin, @parambirs, @eps1lon, @ThomasdenH, @WilcoBakker, @wwwy3y3, @samuela, @kuehlein, @bhongy, @chyzwar, @trivikr, @yoursunny, @qwelias, @ExE-Boss, @peterblazejewicz, @addaleax, @victorperin, @ZYSzys, @nodejs, @LinusU, @wafuwafu13, @mcollina, @Semigradsky.)

[andrewbranch]

This makes import {} from "node/globals" legal 😕 That’s why my _Request et al. types are accessible. There’s no way to hide them without declaring a module.

[thw0rted]

I guess you learn something new every day. When I messed this up last time, nobody seems to have noticed. Does that need to change as well?

Would it be preferable to move these declarations out of globals.d.ts and into some other module context? I was mostly trying to avoid exposing the fictional namespace so that library authors wouldn't come to depend on that implementation detail, but of course I'd defer to the team about which hazard is more important to work around.

[andrewbranch]

Well, if nobody noticed the last one, probably nobody will notice this. I guess it’s fine 😄

If we had a type reference directive condition, we could use it to hide everything from imports while keeping things accessible to type reference directives:

{
  "exports": {
    "./*": {
      "types@>=5.5": {
        "typereference": "./*",
        "default": null
      },
      "default": "./*"
    }
  }
}

🤔

[thw0rted]

Ready to merge

[jordanebelanger]

Hi folks,

I am having an issue which may stem from this PR. Before this PR, RequestCredentials and other types were exported directly.

Now I am trying to make the OpenAPi typescript-fetch code generator work for nodejs and running into an issue whereas it's referencing types such as RequestCredentials directly. This no longer works following this PR as the type is no longer exported directly.

But, this is something that does work in a context where lib.dom is added as a lib.

[thw0rted]

You can try an older version of @types/node but I don't think it ever exposed a global RequestCredentials -- this PR only removed a namespaced re-export of import("undici-types").RequestCredentials. There are a number of helper types (interfaces and enums, mostly) that lib.dom.d.ts exports but which have no runtime value, and this is one of them. You could open a PR to add the helpers listed here in the fetch spec, for compatibility with lib-DOM, if you wanted. I'm not a maintainer, but it seems like a pretty good idea to me.