Port builtin tslint rules #830
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only keep 10; I tried no-redeclare but it doesn't suffice to forbid only duplicated `var` and nothing else because it doesn't understand Typescript syntax or semantics.
jakebailey
approved these changes
Nov 20, 2023
...ages/eslint-plugin/test/__file_snapshots__/types/no-import-of-dev-dependencies/bad.d.ts.lint
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Convert the "good" tslint builtins to their equivalent eslint or typescript-eslint equivalents.
I tried to use no-redeclare to prevent duplicated
vardeclarations, but the eslint rule doesn't understand Typescript syntax and ts-eslint rule doesn't understand Typescript semantics that well (and, a little, its syntax), so had too many false positives.Obviously there are other rules that would be nice to enable, but I'll leave that for others, since there is a lot of testing effort per rule, and these 10 are the ones @jakebailey, @andrewbranch and I thought were the most useful.