Port builtin tslint rules #67455
Merged
Port builtin tslint rules #67455
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's much easier to add .eslintrc.json exemptions, so that's what I did.
sandersn
requested review from
Diullei,
vvakame,
peterblazejewicz,
Igorbek,
horiuchi,
eps1lon,
borisyankov,
Jessidhia,
Bartvds,
rbuckton,
JoshuaKGoldberg,
basarat,
andrewbranch,
johnnyreilly,
DanielRosenwasser,
typescript-bot,
Rick-Kirkham,
ElizabethSamuel-MSFT,
octatone and
alloy
as code owners
jakebailey
reviewed
Nov 20, 2023
jakebailey
approved these changes
Nov 20, 2023
This was referenced Nov 20, 2023
|
There are a few failures, but they all appear to be related to the missing installs of dependencies. None are the lint rules that I recently enabled, so I'm going to merge and watch the overnight run. I expect it will be clean, though. |
jakebailey
added a commit
to jakebailey/DefinitelyTyped
that referenced
this pull request
Nov 21, 2023
sandersn
pushed a commit
that referenced
this pull request
Nov 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The biggest open question is whether it's worthwhile to keep array-type turned on, and fix up DT, or to remove it from the list of rules.
The PR is best viewed by commit since together there are too many changes to view on github.
Edit: Also it's waiting on microsoft/DefinitelyTyped-tools#830 to ship before tests will pass.