-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Pinning operations and error messaging for Dev Box #182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
huzaifa-d
reviewed
May 14, 2024
sshilov7
reviewed
May 15, 2024
{ | ||
try | ||
{ | ||
// This will always result in a returned value in non test scenarios. But will throw when run in a unit test as ApplicationData does not exist. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: You could catch that exception and use Path.GetTempPath() to account for test scenarious.
sshilov7
approved these changes
May 15, 2024
safmswork
reviewed
May 15, 2024
kanismohammed
approved these changes
May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the pull request
Note: Secondary PR in Dev Home repository: microsoft/devhome#2907
This PR makes sure that the pinning operation and errors are reflected in Dev Home. Currently When a pinning operation happens there is no status updates. Dev Home expects for every operation that the Compute System supports that there be a status update to inform the user something is occuring. E.g "Starting".
Things this PR updates:
async void
and usedasync task
in theLoadWindowsAppParameters
method as it was causing the Dev Boxes to randomly not contain the required WindowsAppParameters by the time Dev Home called theGetPinStatusAsync
.Video showing me performing the pinning and unpinning operations:
pinned.to.start.operations.updating.mp4
References and relevant issues
Detailed description of the pull request / Additional comments
Note: Due to the asynchrous calls for
GetPinStatusAsync
, when the operation to pin/upin the dev box is completed, the pin/pinned operations don't reset untilGetPinStatusAsync
is complete so there is a small delay when the operations update. We can work on trying to optimize this reset in a future PR.Validation steps performed
PR checklist