Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes for build failures when using MinGW #95

Merged
merged 2 commits into from Apr 21, 2023
Merged

Fixes for build failures when using MinGW #95

merged 2 commits into from Apr 21, 2023

Conversation

walbourn
Copy link
Member

This fixes build failures with the latest release when using the MinGW toolset.

@Biswa96
Copy link

Biswa96 commented Apr 21, 2023

Would you like to share any compiler or linker output related to that build failure? Just curious.

@walbourn
Copy link
Member Author 

c:\mingw64\x86_64-w64-mingw32\include\rpcndr.h:15:2: error: #error incorrect <rpcndr.h> version. Use the header that matches with the MIDL compiler.
   15 | #error incorrect <rpcndr.h> version. Use the header that matches with the MIDL compiler.

@walbourn walbourn marked this pull request as draft April 21, 2023 18:44
@walbourn
Copy link
Member Author

Working on fixing up the GoogleTest as well for MinGW.

@Biswa96
Copy link

Biswa96 commented Apr 21, 2023

Thanks for the info. I thought that version mismatch was fixed in #93

@walbourn walbourn marked this pull request as ready for review April 21, 2023 18:52
@jenatali jenatali merged commit 34c9866 into main Apr 21, 2023
1 check passed
@jenatali jenatali deleted the mingwfix branch April 21, 2023 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jenatali jenatali jenatali left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@walbourn @Biswa96 @jenatali