Disallow NodeOutput or EmptyNodeOutput array node parameters #5588
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The NodeOutputArray and EmptyNodeOutputArray types are provided for use as node shader parameter types to be used instead of native array types. Add error diagnostics for the use of native NodeOutput or EmptyNodeOutput arrays, and add a corresponding verifier test.
llvm-beanz
reviewed
Sep 21, 2023
There was a problem hiding this comment.
I think this is good with two caveats:
- It will need to be rebased on top of the clang-formatted branch.
- If we can also rebase it on top of Don't string match node type names #5763, we should remove the string matching of type names.
This change just simplifies the underlying implementaiton to avoid string matching and to not need additional HlslTypes functions.
pow2clk
reviewed
Sep 26, 2023
tex3d
reviewed
Sep 27, 2023
tex3d
reviewed
Sep 27, 2023
This change updates the underlying change to emit a diagnostic for all input and output node types when used as entry parameter arrays.
pow2clk
reviewed
Sep 27, 2023
pow2clk
approved these changes
Sep 27, 2023
tex3d
reviewed
Sep 29, 2023
tools/clang/test/HLSLFileCheck/d3dreflect/empty_broadcasting_nodes.hlsl
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The NodeOutputArray and EmptyNodeOutputArray types are provided for use as node shader parameter types to be used instead of native array types.
Add error diagnostics for the use of native NodeOutput or EmptyNodeOutput arrays, and add a corresponding verifier test.
Fixes #5359