Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ResourceUploadBatch updated to support copy & compute queues #71

Merged
merged 8 commits into from
Apr 12, 2020
Merged

ResourceUploadBatch updated to support copy & compute queues #71

merged 8 commits into from
Apr 12, 2020

Conversation

walbourn
Copy link
Member

@walbourn walbourn commented Apr 10, 2020 •
edited

The ResourceUploadBatch as originally implemented only worked on DIRECT command queues, which are the kind created by DeviceResources.

This PR adds supports for both COPY and COMPUTE command queues as an option.

  • COPY queues only support loading. They cannot support GenerateMips

  • COMPUTE queues can support the current features.

The only other supported command queue types are VIDEO_* which are not relevant here.

@walbourn walbourn mentioned this pull request Apr 10, 2020
Closed
@walbourn
Copy link
Member Author

For test coverage, see this PR

@walbourn walbourn requested a review from shawnhar April 10, 2020 20:28
@walbourn walbourn self-assigned this Apr 11, 2020
@walbourn walbourn merged commit cc4bcb2 into master Apr 12, 2020
@walbourn walbourn deleted the copyqueuesupport branch April 12, 2020 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shawnhar shawnhar Awaiting requested review from shawnhar

Assignees

@walbourn walbourn

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@walbourn