Improved testcase to cover object logs with non-zero segment offset, …

…added correctness checking for all keys during read.

cs/test/ObjectRecoveryTest2.cs

@@ -12,7 +12,7 @@ namespace FASTER.test.recovery.objects
     [TestFixture]
     public class ObjectRecoveryTest
     {
-        static readonly int iterations = 21;
+        int iterations;
         string FasterFolderPath { get; set; }
 
         [SetUp]
@@ -52,12 +52,15 @@ public static void DeleteDirectory(string path)
 
 
         [Test]
-        public void ObjectRecoveryTest1([Values]CheckpointType checkpointType)
+        public void ObjectRecoveryTest1(
+            [Values]CheckpointType checkpointType,
+            [Range(100, 1500, 600)] int iterations)
         {
+            this.iterations = iterations;
             Prepare(checkpointType, out _, out _, out IDevice log, out IDevice objlog, out FasterKV<MyKey, MyValue, MyInput, MyOutput, MyContext, MyFunctions> h, out MyContext context);
 
             var session1 = h.NewSession();
-            Write(session1, context);
+            Write(session1, context, h);
             Read(session1, context, false);
             session1.Dispose();
 
@@ -90,8 +93,8 @@ private void Prepare(CheckpointType checkpointType, out string logPath, out stri
                 {
                     LogDevice = log,
                     ObjectLogDevice = objlog,
-                    SegmentSizeBits = 10,
-                    MemorySizeBits = 10,
+                    SegmentSizeBits = 12,
+                    MemorySizeBits = 12,
                     PageSizeBits = 9
                 },
                 new CheckpointSettings()
@@ -112,48 +115,48 @@ private static void Destroy(IDevice log, IDevice objlog, FasterKV<MyKey, MyValue
             objlog.Close();
         }
 
-        private void Write(ClientSession<MyKey, MyValue, MyInput, MyOutput, MyContext, MyFunctions> h, MyContext context)
+        private void Write(ClientSession<MyKey, MyValue, MyInput, MyOutput, MyContext, MyFunctions> session, MyContext context, FasterKV<MyKey, MyValue, MyInput, MyOutput, MyContext, MyFunctions> fht)
         {
             for (int i = 0; i < iterations; i++)
             {
                 var _key = new MyKey { key = i, name = i.ToString() };
                 var value = new MyValue { value = i.ToString() };
-                h.Upsert(ref _key, ref value, context, 0);
+                session.Upsert(ref _key, ref value, context, 0);
+
+                if (i % 100 == 0)
+                {
+                    fht.TakeFullCheckpoint(out _);
+                    fht.CompleteCheckpointAsync().GetAwaiter().GetResult();
+                }
             }
         }
 
         private void Read(ClientSession<MyKey, MyValue, MyInput, MyOutput, MyContext, MyFunctions> session, MyContext context, bool delete)
         {
-            var key = new MyKey { key = 1, name = "1" };
-            var input = default(MyInput);
-            MyOutput g1 = new MyOutput();
-            var status = session.Read(ref key, ref input, ref g1, context, 0);
-
-            if (status == Status.PENDING)
+            for (int i = 0; i < iterations; i++)
             {
-                session.CompletePending(true);
-                context.FinalizeRead(ref status, ref g1);
-            }
-
-            Assert.IsTrue(status == Status.OK);
+                var key = new MyKey { key = i, name = i.ToString() };
+                var input = default(MyInput);
+                MyOutput g1 = new MyOutput();
+                var status = session.Read(ref key, ref input, ref g1, context, 0);
 
-            MyOutput g2 = new MyOutput();
-            key = new MyKey { key = 2, name = "2" };
-            status = session.Read(ref key, ref input, ref g2, context, 0);
+                if (status == Status.PENDING)
+                {
+                    session.CompletePending(true);
+                    context.FinalizeRead(ref status, ref g1);
+                }
 
-            if (status == Status.PENDING)
-            {
-                session.CompletePending(true);
-                context.FinalizeRead(ref status, ref g2);
+                Assert.IsTrue(status == Status.OK);
+                Assert.IsTrue(g1.value.value == i.ToString());
             }
 
-            Assert.IsTrue(status == Status.OK);
-
             if (delete)
             {
+                var key = new MyKey { key = 1, name = "1" };
+                var input = default(MyInput);
                 var output = new MyOutput();
                 session.Delete(ref key, context, 0);
-                status = session.Read(ref key, ref input, ref output, context, 0);
+                var status = session.Read(ref key, ref input, ref output, context, 0);
 
                 if (status == Status.PENDING)
                 {