Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve Code Quality #264

Merged
merged 7 commits into from
Apr 21, 2020
Merged

Improve Code Quality #264

merged 7 commits into from
Apr 21, 2020

Conversation

iamcarbon
Copy link
Contributor

  • Adds readonly annotations to various struct members (helping prevent silent copies)
  • Seals various classes to improve devirtualization and minimize downstream inherence until API is locked down
  • Removes unused using statements
  • Passes a few structs by readonly ref that read their fields

@badrishc
Copy link
Contributor

I had to make a minor path fix in master (debug nuspec).

@iamcarbon
Copy link
Contributor Author

Merged. Should have caught that myself in the last PR.

@badrishc badrishc merged commit 0de60be into microsoft:master Apr 21, 2020
@badrishc
Copy link
Contributor

Merged, thank you for the contribution!

@iamcarbon iamcarbon deleted the ro2 branch April 21, 2020 02:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@iamcarbon @badrishc