Add check for large for loops #361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BoyaWu10
requested review from
hongyh13,
ACMoretxj,
qiwjin,
sowu880,
moria97 and
yankunhuang-pku
sowu880
approved these changes
Mar 15, 2022
qiwjin
reviewed
Mar 16, 2022
| @@ -18,6 +18,7 @@ namespace Microsoft.Health.Fhir.Liquid.Converter.Processors | |||
| public abstract class BaseProcessor : IFhirConverter | |||
| { | |||
| private readonly ProcessorSettings _settings; | |||
| private const int _maxIterations = 100000; | |||
There was a problem hiding this comment.
can you help doc this limitation?
There was a problem hiding this comment.
Hi @ginalee-dotcom, could you please help create a PR to update the document about this change? The maximum iteration of for-loop in liquid templates is now set to 100,000. Previously there's no limitation about this. If the limitation is reached, an exception will be thrown with detailed message. This is to help make sure our engine returns a result in time.
qiwjin
approved these changes
Mar 16, 2022
moria97
approved these changes
Mar 16, 2022
ACMoretxj
reviewed
Mar 16, 2022
yankunhuang-pku
approved these changes
Mar 16, 2022
ACMoretxj
approved these changes
Mar 16, 2022
jakiefermsft
added a commit
to jasonheld-msft/FHIR-Converter
that referenced
this pull request
Apr 26, 2022
…fer/pgcritiques-merge * 'main' of github.com:microsoft/FHIR-Converter: Global Readiness Manifest file GeoPol.xml Update version (microsoft#375) Remove blank lines (microsoft#374) Update Doc for Filters (microsoft#365) Switch FormatAsDateTime timezone handling to preserve to maintain consistency (microsoft#358) Revert "reset to local (microsoft#368)" reset to local (microsoft#368) Phase -2, Milestone-3 Mapping (microsoft#366) Change Default Time Zone Handling (microsoft#363) Turn on mac functional test check (microsoft#367) Fix warnings (microsoft#364) Fix Time Zone Bug (microsoft#353) Phase2 - Milestone 1&2 Mapping (microsoft#354) Add check for large for loops (microsoft#361) Updated the logic of checking the number of default templates Update pipeline win host version (microsoft#359)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By offline discussion, we are going to limit the number of the list in the for loop by the
maxIterationsparameter provided by dotliquid. Currently the value is set to 100000.