Change Default Time Zone Handling #363
Conversation
sowu880
commented
Mar 21, 2022
•
sowu880
commented
- Change default time zone handling for FormatAsDateTime() API from "local" to "preserve".
- Output of dateTime filters should be valid FHIR format with time zone.
sowu880
force-pushed
the
personal/sowu/default-timezone-handling
branch
from
108916b
to
2dc1525
Compare
|
Do we need to update the functional test as well? It seems that the pipeline in Mac fails after this change. |
|
Why do we need to modify so many sample data and functional tests? It seems that in this pipeline, all functional tests under windows can pass, and only one test in MAC fails |
Since we changed the time zone handling methods( change 'local' to 'preserve'). Although all tests except one passed, the expected result is incorrect base our new datetime handling methods. |
| @@ -246,6 +246,9 @@ public void GivenCcdaDocument_WhenConverting_ExpectedFhirResourceShouldBeReturne | |||
| var expectedContent = File.ReadAllText(expectedFile); | |||
| var actualContent = ccdaProcessor.Convert(inputContent, rootTemplate, new TemplateProvider(templateDirectory, DataType.Ccda)); | |||
|
|
|||
| var newPath = expectedFile.Replace("Ccda", "newCcda"); | |||
| Directory.CreateDirectory(Path.GetDirectoryName(newPath)); | |||
| File.WriteAllText(newPath, actualContent); | |||
… into personal/sowu/default-timezone-handling
sowu880
force-pushed
the
personal/sowu/default-timezone-handling
branch
from
6ef2dfa
to
5ce0346
Compare
|
/azp run |
|
Azure Pipelines failed to run 1 pipeline(s). |
…fer/pgcritiques-merge * 'main' of github.com:microsoft/FHIR-Converter: Global Readiness Manifest file GeoPol.xml Update version (microsoft#375) Remove blank lines (microsoft#374) Update Doc for Filters (microsoft#365) Switch FormatAsDateTime timezone handling to preserve to maintain consistency (microsoft#358) Revert "reset to local (microsoft#368)" reset to local (microsoft#368) Phase -2, Milestone-3 Mapping (microsoft#366) Change Default Time Zone Handling (microsoft#363) Turn on mac functional test check (microsoft#367) Fix warnings (microsoft#364) Fix Time Zone Bug (microsoft#353) Phase2 - Milestone 1&2 Mapping (microsoft#354) Add check for large for loops (microsoft#361) Updated the logic of checking the number of default templates Update pipeline win host version (microsoft#359)
